upstream/mercurial-mirror Files · mercurial/dicthelpers.py

hgweb: fail if an invalid command was supplied in url path (issue4071)...

hgweb: fail if an invalid command was supplied in url path (issue4071) Traditionally, the way to specify a command for hgweb was to use url query arguments (e.g. "?cmd=batch"). If the command is unknown to hgweb, it gives an error (e.g. "400 no such method: badcmd"). But there's also another way to specify a command: as a url path fragment (e.g. "/graph"). Before, hgweb was made forgiving (looks like it was made in 44c5157474e7) and user could put any unknown command in the url. If hgweb couldn't understand it, it would just silently fall back to the default command, which depends on the actual style (e.g. for paper it's shortlog, for monoblue it's summary). This was inconsistent and was breaking some tools that rely on http status codes (as noted in the issue4071). So this patch changes that behavior to the more consistent one, i.e. hgweb will now return "400 no such method: badcmd". So if some tool was relying on having an invalid command return http status code 200 and also have some information, then it will stop working. That is, if somebody typed foobar when they really meant shortlog (and the user was lucky enough to choose a style where the default command is shortlog too), that fact will now be revealed. Code-wise, the changed if block is only relevant when there's no "?cmd" query parameter (i.e. only when command is specified as a url path fragment), and looks like the removed else branch was there only for falling back to default command. With that removed, the rest of the code works as expected: it looks at the command, and if it's not known, raises a proper ErrorResponse exception with an appropriate message. Evidently, there were no tests that required the old behavior. But, frankly, I don't know any way to tell if anyone actually exploited such forgiving behavior in some in-house tool.

Siddharth Agarwal - - Load All Authors

File last commit:

r18894:ed46c2b9 default


                r22506:6e1fbcb1

stable

Download file

             dicthelpers.py
        
                    55 lines
            
             | 1.6 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / dicthelpers.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # dicthelpers.py - helper routines for Python dicts

      #

      # Copyright 2013 Facebook

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      def diff(d1, d2, default=None):

          '''Return all key-value pairs that are different between d1 and d2.

          This includes keys that are present in one dict but not the other, and

          keys whose values are different. The return value is a dict with values

          being pairs of values from d1 and d2 respectively, and missing values

          treated as default, so if a value is missing from one dict and the same as

          default in the other, it will not be returned.'''

          res = {}

          if d1 is d2:

              # same dict, so diff is empty

              return res

          for k1, v1 in d1.iteritems():

              v2 = d2.get(k1, default)

              if v1 != v2:

                  res[k1] = (v1, v2)

          for k2 in d2:

              if k2 not in d1:

                  v2 = d2[k2]

                  if v2 != default:

                      res[k2] = (default, v2)

          return res

      def join(d1, d2, default=None):

          '''Return all key-value pairs from both d1 and d2.

          This is akin to an outer join in relational algebra. The return value is a

          dict with values being pairs of values from d1 and d2 respectively, and

          missing values represented as default.'''

          res = {}

          for k1, v1 in d1.iteritems():

              if k1 in d2:

                  res[k1] = (v1, d2[k1])

              else:

                  res[k1] = (v1, default)

          if d1 is d2:

              return res

          for k2 in d2:

              if k2 not in d1:

                  res[k2] = (default, d2[k2])

          return res

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# dicthelpers.py - helper routines for Python dicts
				#
				# Copyright 2013 Facebook
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				def diff(d1, d2, default=None):
				'''Return all key-value pairs that are different between d1 and d2.

				This includes keys that are present in one dict but not the other, and
				keys whose values are different. The return value is a dict with values
				being pairs of values from d1 and d2 respectively, and missing values
				treated as default, so if a value is missing from one dict and the same as
				default in the other, it will not be returned.'''
				res = {}
				if d1 is d2:
				# same dict, so diff is empty
				return res

				for k1, v1 in d1.iteritems():
				v2 = d2.get(k1, default)
				if v1 != v2:
				res[k1] = (v1, v2)

				for k2 in d2:
				if k2 not in d1:
				v2 = d2[k2]
				if v2 != default:
				res[k2] = (default, v2)

				return res

				def join(d1, d2, default=None):
				'''Return all key-value pairs from both d1 and d2.

				This is akin to an outer join in relational algebra. The return value is a
				dict with values being pairs of values from d1 and d2 respectively, and
				missing values represented as default.'''
				res = {}

				for k1, v1 in d1.iteritems():
				if k1 in d2:
				res[k1] = (v1, d2[k1])
				else:
				res[k1] = (v1, default)

				if d1 is d2:
				return res

				for k2 in d2:
				if k2 not in d1:
				res[k2] = (default, d2[k2])

				return res