upstream/mercurial-mirror Files · rust/hg-cpython/src/conversion.rs

dirstate-tree: Fold "tracked descendants" counter update in main walk...

dirstate-tree: Fold "tracked descendants" counter update in main walk For the purpose of implementing `has_tracked_dir` (which means "has tracked descendants) without an expensive sub-tree traversal, we maintaing a counter of tracked descendants on each "directory" node of the tree-shaped dirstate. Before this changeset, mutating or inserting a node at a given path would involve: * Walking the tree from root through ancestors to find the node or the spot where to insert it * Looking at the previous node if any to decide what counter update is needed * Performing any node mutation * Walking the tree *again* to update counters in ancestor nodes When profiling `hg status` on a large repo, this second walk takes times while loading a the dirstate from disk. It turns out we have enough information to decide before he first tree walk what counter update is needed. This changeset merges the two walks, gaining ~10% of the total time for `hg update` (in the same hyperfine benchmark as the previous changeset). --- Profiling was done by compiling with this `.cargo/config`: [profile.release] debug = true then running with: py-spy record -r 500 -n -o /tmp/hg.json --format speedscope -- \ ./hg status -R $REPO --config experimental.dirstate-tree.in-memory=1 then visualizing the recorded JSON file in https://www.speedscope.app/ Differential Revision: https://phab.mercurial-scm.org/D10554

Georges Racinet - - Load All Authors

File last commit:

r43563:33fe96a5 default


                r47890:7109a388

default

Download file

             conversion.rs
        
                    28 lines
            
             | 1.0 KiB
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-cpython / src / conversion.rs
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      // conversion.rs

      //

      // Copyright 2019 Georges Racinet <georges.racinet@octobus.net>

      //

      // This software may be used and distributed according to the terms of the

      // GNU General Public License version 2 or any later version.

      //! Bindings for the hg::ancestors module provided by the

      //! `hg-core` crate. From Python, this will be seen as `rustext.ancestor`

      use cpython::{ObjectProtocol, PyObject, PyResult, Python};

      use hg::Revision;

      use std::iter::FromIterator;

      /// Utility function to convert a Python iterable into various collections

      ///

      /// We need this in particular to feed to various methods of inner objects

      /// with `impl IntoIterator<Item=Revision>` arguments, because

      /// a `PyErr` can arise at each step of iteration, whereas these methods

      /// expect iterables over `Revision`, not over some `Result<Revision, PyErr>`

      pub fn rev_pyiter_collect<C>(py: Python, revs: &PyObject) -> PyResult<C>

      where

          C: FromIterator<Revision>,

      {

          revs.iter(py)?

              .map(|r| r.and_then(|o| o.extract::<Revision>(py)))

              .collect()

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				// conversion.rs
				//
				// Copyright 2019 Georges Racinet <georges.racinet@octobus.net>
				//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

				//! Bindings for the hg::ancestors module provided by the
				//! `hg-core` crate. From Python, this will be seen as `rustext.ancestor`

				use cpython::{ObjectProtocol, PyObject, PyResult, Python};
				use hg::Revision;
				use std::iter::FromIterator;

				/// Utility function to convert a Python iterable into various collections
				///
				/// We need this in particular to feed to various methods of inner objects
				/// with `impl IntoIterator<Item=Revision>` arguments, because
				/// a `PyErr` can arise at each step of iteration, whereas these methods
				/// expect iterables over `Revision`, not over some `Result<Revision, PyErr>`
				pub fn rev_pyiter_collect<C>(py: Python, revs: &PyObject) -> PyResult<C>
				where
				C: FromIterator<Revision>,
				{
				revs.iter(py)?
				.map(\|r\| r.and_then(\|o\| o.extract::<Revision>(py)))
				.collect()
				}