upstream/mercurial-mirror Files · hgext/hooklib/reject_merge_commits.py

refactor: prefer checks against nullrev over nullid...

refactor: prefer checks against nullrev over nullid A common pattern is using a changeset context and obtaining the node to compare against nullid. Change this to obtain the nullrev instead. In the future, the nullid becomes a property of the repository and is no longer a global constant, so using nullrev is much easier to reason about. Python function call overhead makes the difference moot, but future changes will result in more dictionary lookups otherwise, so prefer the simpler pattern. Differential Revision: https://phab.mercurial-scm.org/D10290

Joerg Sonnenberger - - Load All Authors

File last commit:

r44897:4cabeea6 default


                r47601:728d89f6

default

Download file

             reject_merge_commits.py
        
                    45 lines
            
             | 1.3 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / hooklib / reject_merge_commits.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Copyright 2020 Joerg Sonnenberger <joerg@bec.de>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      """reject_merge_commits is a hook to check new changesets for merge commits.

      Merge commits are allowed only between different branches, i.e. merging

      a feature branch into the main development branch. This can be used to

      enforce policies for linear commit histories.

      Usage:

        [hooks]

        pretxnchangegroup.reject_merge_commits = \

          python:hgext.hooklib.reject_merge_commits.hook

      """

      from __future__ import absolute_import

      from mercurial.i18n import _

      from mercurial import (

          error,

          pycompat,

      )

      def hook(ui, repo, hooktype, node=None, **kwargs):

          if hooktype != b"pretxnchangegroup":

              raise error.Abort(

                  _(b'Unsupported hook type %r') % pycompat.bytestr(hooktype)

              )

          ctx = repo.unfiltered()[node]

          for rev in repo.changelog.revs(start=ctx.rev()):

              rev = repo[rev]

              parents = rev.parents()

              if len(parents) < 2:

                  continue

              if all(repo[p].branch() == rev.branch() for p in parents):

                  raise error.Abort(

                      _(

                          b'%s rejected as merge on the same branch. '

                          b'Please consider rebase.'

                      )

                      % rev

                  )

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Copyright 2020 Joerg Sonnenberger <joerg@bec.de>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				"""reject_merge_commits is a hook to check new changesets for merge commits.
				Merge commits are allowed only between different branches, i.e. merging
				a feature branch into the main development branch. This can be used to
				enforce policies for linear commit histories.

				Usage:
				[hooks]
				pretxnchangegroup.reject_merge_commits = \
				python:hgext.hooklib.reject_merge_commits.hook
				"""

				from __future__ import absolute_import

				from mercurial.i18n import _
				from mercurial import (
				error,
				pycompat,
				)


				def hook(ui, repo, hooktype, node=None, **kwargs):
				if hooktype != b"pretxnchangegroup":
				raise error.Abort(
				_(b'Unsupported hook type %r') % pycompat.bytestr(hooktype)
				)

				ctx = repo.unfiltered()[node]
				for rev in repo.changelog.revs(start=ctx.rev()):
				rev = repo[rev]
				parents = rev.parents()
				if len(parents) < 2:
				continue
				if all(repo[p].branch() == rev.branch() for p in parents):
				raise error.Abort(
				_(
				b'%s rejected as merge on the same branch. '
				b'Please consider rebase.'
				)
				% rev
				)