##// END OF EJS Templates
tests: disable a section of `test-hgrc.t` that may hit a zeroconf bug...
tests: disable a section of `test-hgrc.t` that may hit a zeroconf bug This effectively re-disables the same test as cce9e7d2fb92, but unconditionally because it's not a pyoxidizer-specific problem (see below and 997c9b2069d1). I can run the test locally fine, with the same venv as CI is using, and have had multiple CI runs that don't hit this. But one failed with this: --- /private/tmp/mercurial-ci/tests/test-hgrc.t +++ /private/tmp/mercurial-ci/tests/test-hgrc.t.err @@ -305,5 +305,17 @@ [255] $ HGRCSKIPREPO=1 hg paths --config extensions.zeroconf= + Traceback (most recent call last): + File "/private/tmp/hgtests.7idf706t/install/lib/python/hgext/zeroconf/Zeroconf.py", line 966, in run + self.readers[sock].handle_read() + File "/private/tmp/hgtests.7idf706t/install/lib/python/hgext/zeroconf/Zeroconf.py", line 1020, in handle_read + msg = DNSIncoming(data) + File "/private/tmp/hgtests.7idf706t/install/lib/python/hgext/zeroconf/Zeroconf.py", line 537, in __init__ + self.readOthers() + File "/private/tmp/hgtests.7idf706t/install/lib/python/hgext/zeroconf/Zeroconf.py", line 650, in readOthers + self.readCharacterString(), + File "/private/tmp/hgtests.7idf706t/install/lib/python/hgext/zeroconf/Zeroconf.py", line 584, in readCharacterString + length = ord(self.data[self.offset]) + TypeError: ord() expected string of length 1, but int found foo = $TESTTMP/bar The zeroconf extension has bytes vs str problems that are obvious from inspection alone, and nobody has complained, so I'm not going to let this block getting CI for macOS up and running. Given that it's in the packet read code, I suspect that this 1) requires something on the network to speak mDNS, and 2) it is a timing issue if this is seen or not. (The bytes vs str issue itself is real, but only happen if a response is received quickly.)

File last commit:

r50408:467d9df9 default
r53048:74e16d8c stable
Show More
plain_info.rs
79 lines | 2.2 KiB | application/rls-services+xml | RustLexer
use crate::utils::files::get_bytes_from_os_string;
use std::env;
/// Keeps information on whether plain mode is active.
///
/// Plain mode means that all configuration variables which affect
/// the behavior and output of Mercurial should be
/// ignored. Additionally, the output should be stable,
/// reproducible and suitable for use in scripts or applications.
///
/// The only way to trigger plain mode is by setting either the
/// `HGPLAIN' or `HGPLAINEXCEPT' environment variables.
///
/// The return value can either be
/// - False if HGPLAIN is not set, or feature is in HGPLAINEXCEPT
/// - False if feature is disabled by default and not included in HGPLAIN
/// - True otherwise
#[derive(Clone)]
pub struct PlainInfo {
is_plain: bool,
except: Vec<Vec<u8>>,
}
impl PlainInfo {
fn plain_except(except: Vec<Vec<u8>>) -> Self {
PlainInfo {
is_plain: true,
except,
}
}
pub fn empty() -> PlainInfo {
PlainInfo {
is_plain: false,
except: vec![],
}
}
pub fn from_env() -> PlainInfo {
if let Some(except) = env::var_os("HGPLAINEXCEPT") {
PlainInfo::plain_except(
get_bytes_from_os_string(except)
.split(|&byte| byte == b',')
.map(|x| x.to_vec())
.collect(),
)
} else {
PlainInfo {
is_plain: env::var_os("HGPLAIN").is_some(),
except: vec![],
}
}
}
pub fn is_feature_plain(&self, feature: &str) -> bool {
return self.is_plain
&& !self
.except
.iter()
.any(|exception| exception.as_slice() == feature.as_bytes());
}
pub fn is_plain(&self) -> bool {
self.is_plain
}
pub fn plainalias(&self) -> bool {
self.is_feature_plain("alias")
}
pub fn plainrevsetalias(&self) -> bool {
self.is_feature_plain("revsetalias")
}
pub fn plaintemplatealias(&self) -> bool {
self.is_feature_plain("templatealias")
}
pub fn plaintweakdefaults(&self) -> bool {
self.is_feature_plain("tweakdefaults")
}
}