upstream/mercurial-mirror Files · contrib/fixpax.py

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Pulkit Goyal - - Load All Authors

File last commit:

r28354:00f31778 default


                r32050:77eaf953

4.1.3 stable

Download file

             fixpax.py
        
                    64 lines
            
             | 1.6 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / contrib / fixpax.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/usr/bin/env python

      # fixpax - fix ownership in bdist_mpkg output

      #

      # Copyright 2015 Matt Mackall <mpm@selenic.com>

      #

      # This software may be used and distributed according to the terms of the

      # MIT license (http://opensource.org/licenses/MIT)

      """Set file ownership to 0 in an Archive.pax.gz.

      Suitable for fixing files bdist_mpkg output:

      *.mpkg/Contents/Packages/*.pkg/Contents/Archive.pax.gz

      """

      from __future__ import absolute_import, print_function

      import gzip

      import os

      import sys

      def fixpax(iname, oname):

          i = gzip.GzipFile(iname)

          o = gzip.GzipFile(oname, "w")

          while True:

              magic = i.read(6)

              dev = i.read(6)

              ino = i.read(6)

              mode = i.read(6)

              i.read(6) # uid

              i.read(6) # gid

              nlink = i.read(6)

              rdev = i.read(6)

              mtime = i.read(11)

              namesize = i.read(6)

              filesize = i.read(11)

              name = i.read(int(namesize, 8))

              data = i.read(int(filesize, 8))

              o.write(magic)

              o.write(dev)

              o.write(ino)

              o.write(mode)

              o.write("000000")

              o.write("000000")

              o.write(nlink)

              o.write(rdev)

              o.write(mtime)

              o.write(namesize)

              o.write(filesize)

              o.write(name)

              o.write(data)

              if name.startswith("TRAILER!!!"):

                  o.write(i.read())

                  break

          o.close()

          i.close()

      if __name__ == '__main__':

          for iname in sys.argv[1:]:

              print('fixing file ownership in %s' % iname)

              oname = sys.argv[1] + '.tmp'

              fixpax(iname, oname)

              os.rename(oname, iname)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/usr/bin/env python
				# fixpax - fix ownership in bdist_mpkg output
				#
				# Copyright 2015 Matt Mackall <mpm@selenic.com>
				#
				# This software may be used and distributed according to the terms of the
				# MIT license (http://opensource.org/licenses/MIT)

				"""Set file ownership to 0 in an Archive.pax.gz.
				Suitable for fixing files bdist_mpkg output:
				.mpkg/Contents/Packages/.pkg/Contents/Archive.pax.gz
				"""

				from __future__ import absolute_import, print_function
				import gzip
				import os
				import sys

				def fixpax(iname, oname):
				i = gzip.GzipFile(iname)
				o = gzip.GzipFile(oname, "w")

				while True:
				magic = i.read(6)
				dev = i.read(6)
				ino = i.read(6)
				mode = i.read(6)
				i.read(6) # uid
				i.read(6) # gid
				nlink = i.read(6)
				rdev = i.read(6)
				mtime = i.read(11)
				namesize = i.read(6)
				filesize = i.read(11)
				name = i.read(int(namesize, 8))
				data = i.read(int(filesize, 8))

				o.write(magic)
				o.write(dev)
				o.write(ino)
				o.write(mode)
				o.write("000000")
				o.write("000000")
				o.write(nlink)
				o.write(rdev)
				o.write(mtime)
				o.write(namesize)
				o.write(filesize)
				o.write(name)
				o.write(data)

				if name.startswith("TRAILER!!!"):
				o.write(i.read())
				break

				o.close()
				i.close()

				if __name__ == '__main__':
				for iname in sys.argv[1:]:
				print('fixing file ownership in %s' % iname)
				oname = sys.argv[1] + '.tmp'
				fixpax(iname, oname)
				os.rename(oname, iname)