##// END OF EJS Templates
dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...
dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

File last commit:

r30895:c32454d6 default
r32050:77eaf953 4.1.3 stable
Show More
dictparams.c
125 lines | 3.9 KiB | text/x-c | CLexer
/**
* Copyright (c) 2016-present, Gregory Szorc
* All rights reserved.
*
* This software may be modified and distributed under the terms
* of the BSD license. See the LICENSE file for details.
*/
#include "python-zstandard.h"
PyDoc_STRVAR(DictParameters__doc__,
"DictParameters: low-level control over dictionary generation");
static PyObject* DictParameters_new(PyTypeObject* subtype, PyObject* args, PyObject* kwargs) {
DictParametersObject* self;
unsigned selectivityLevel;
int compressionLevel;
unsigned notificationLevel;
unsigned dictID;
if (!PyArg_ParseTuple(args, "IiII", &selectivityLevel, &compressionLevel,
&notificationLevel, &dictID)) {
return NULL;
}
self = (DictParametersObject*)subtype->tp_alloc(subtype, 1);
if (!self) {
return NULL;
}
self->selectivityLevel = selectivityLevel;
self->compressionLevel = compressionLevel;
self->notificationLevel = notificationLevel;
self->dictID = dictID;
return (PyObject*)self;
}
static void DictParameters_dealloc(PyObject* self) {
PyObject_Del(self);
}
static Py_ssize_t DictParameters_length(PyObject* self) {
return 4;
}
static PyObject* DictParameters_item(PyObject* o, Py_ssize_t i) {
DictParametersObject* self = (DictParametersObject*)o;
switch (i) {
case 0:
return PyLong_FromLong(self->selectivityLevel);
case 1:
return PyLong_FromLong(self->compressionLevel);
case 2:
return PyLong_FromLong(self->notificationLevel);
case 3:
return PyLong_FromLong(self->dictID);
default:
PyErr_SetString(PyExc_IndexError, "index out of range");
return NULL;
}
}
static PySequenceMethods DictParameters_sq = {
DictParameters_length, /* sq_length */
0, /* sq_concat */
0, /* sq_repeat */
DictParameters_item, /* sq_item */
0, /* sq_ass_item */
0, /* sq_contains */
0, /* sq_inplace_concat */
0 /* sq_inplace_repeat */
};
PyTypeObject DictParametersType = {
PyVarObject_HEAD_INIT(NULL, 0)
"DictParameters", /* tp_name */
sizeof(DictParametersObject), /* tp_basicsize */
0, /* tp_itemsize */
(destructor)DictParameters_dealloc, /* tp_dealloc */
0, /* tp_print */
0, /* tp_getattr */
0, /* tp_setattr */
0, /* tp_compare */
0, /* tp_repr */
0, /* tp_as_number */
&DictParameters_sq, /* tp_as_sequence */
0, /* tp_as_mapping */
0, /* tp_hash */
0, /* tp_call */
0, /* tp_str */
0, /* tp_getattro */
0, /* tp_setattro */
0, /* tp_as_buffer */
Py_TPFLAGS_DEFAULT, /* tp_flags */
DictParameters__doc__, /* tp_doc */
0, /* tp_traverse */
0, /* tp_clear */
0, /* tp_richcompare */
0, /* tp_weaklistoffset */
0, /* tp_iter */
0, /* tp_iternext */
0, /* tp_methods */
0, /* tp_members */
0, /* tp_getset */
0, /* tp_base */
0, /* tp_dict */
0, /* tp_descr_get */
0, /* tp_descr_set */
0, /* tp_dictoffset */
0, /* tp_init */
0, /* tp_alloc */
DictParameters_new, /* tp_new */
};
void dictparams_module_init(PyObject* mod) {
Py_TYPE(&DictParametersType) = &PyType_Type;
if (PyType_Ready(&DictParametersType) < 0) {
return;
}
Py_IncRef((PyObject*)&DictParametersType);
PyModule_AddObject(mod, "DictParameters", (PyObject*)&DictParametersType);
}