upstream/mercurial-mirror Files · tests/printenv.py

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Robert Stanca - - Load All Authors

File last commit:

r28944:036787c1 default


                r32050:77eaf953

4.1.3 stable

Download file

             printenv.py
        
                    52 lines
            
             | 1.3 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / printenv.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/usr/bin/env python

      #

      # simple script to be used in hooks

      #

      # put something like this in the repo .hg/hgrc:

      #

      #     [hooks]

      #     changegroup = python "$TESTDIR/printenv.py" <hookname> [exit] [output]

      #

      #   - <hookname> is a mandatory argument (e.g. "changegroup")

      #   - [exit] is the exit code of the hook (default: 0)

      #   - [output] is the name of the output file (default: use sys.stdout)

      #              the file will be opened in append mode.

      #

      from __future__ import absolute_import

      import os

      import sys

      try:

          import msvcrt

          msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)

          msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)

          msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY)

      except ImportError:

          pass

      exitcode = 0

      out = sys.stdout

      name = sys.argv[1]

      if len(sys.argv) > 2:

          exitcode = int(sys.argv[2])

          if len(sys.argv) > 3:

              out = open(sys.argv[3], "ab")

      # variables with empty values may not exist on all platforms, filter

      # them now for portability sake.

      env = [(k, v) for k, v in os.environ.iteritems()

             if k.startswith("HG_") and v]

      env.sort()

      out.write("%s hook: " % name)

      if os.name == 'nt':

          filter = lambda x: x.replace('\\', '/')

      else:

          filter = lambda x: x

      vars = ["%s=%s" % (k, filter(v)) for k, v in env]

      out.write(" ".join(vars))

      out.write("\n")

      out.close()

      sys.exit(exitcode)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/usr/bin/env python
				#
				# simple script to be used in hooks
				#
				# put something like this in the repo .hg/hgrc:
				#
				# [hooks]
				# changegroup = python "$TESTDIR/printenv.py" <hookname> [exit] [output]
				#
				# - <hookname> is a mandatory argument (e.g. "changegroup")
				# - [exit] is the exit code of the hook (default: 0)
				# - [output] is the name of the output file (default: use sys.stdout)
				# the file will be opened in append mode.
				#
				from __future__ import absolute_import
				import os
				import sys

				try:
				import msvcrt
				msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)
				msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)
				msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY)
				except ImportError:
				pass

				exitcode = 0
				out = sys.stdout

				name = sys.argv[1]
				if len(sys.argv) > 2:
				exitcode = int(sys.argv[2])
				if len(sys.argv) > 3:
				out = open(sys.argv[3], "ab")

				# variables with empty values may not exist on all platforms, filter
				# them now for portability sake.
				env = [(k, v) for k, v in os.environ.iteritems()
				if k.startswith("HG_") and v]
				env.sort()

				out.write("%s hook: " % name)
				if os.name == 'nt':
				filter = lambda x: x.replace('\\', '/')
				else:
				filter = lambda x: x
				vars = ["%s=%s" % (k, filter(v)) for k, v in env]
				out.write(" ".join(vars))
				out.write("\n")
				out.close()

				sys.exit(exitcode)