upstream/mercurial-mirror Files · tests/test-lock-badness.t

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Mark Ignacio - - Load All Authors

File last commit:

r29883:0c8c388c default


                r32050:77eaf953

4.1.3 stable

Download file

             test-lock-badness.t
        
                    78 lines
            
             | 2.0 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-lock-badness.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require unix-permissions no-root no-windows

      Prepare

        $ hg init a

        $ echo a > a/a

        $ hg -R a ci -A -m a

        adding a

        $ hg clone a b

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

      Test that raising an exception in the release function doesn't cause the lock to choke

        $ cat > testlock.py << EOF

        > from mercurial import cmdutil, error, error

        > 

        > cmdtable = {}

        > command = cmdutil.command(cmdtable)

        > 

        > def acquiretestlock(repo, releaseexc):

        >     def unlock():

        >         if releaseexc:

        >             raise error.Abort('expected release exception')

        >     l = repo._lock(repo.vfs, 'testlock', False, unlock, None, 'test lock')

        >     return l

        > 

        > @command('testlockexc')

        > def testlockexc(ui, repo):

        >     testlock = acquiretestlock(repo, True)

        >     try:

        >         testlock.release()

        >     finally:

        >         try:

        >             testlock = acquiretestlock(repo, False)

        >         except error.LockHeld:

        >             raise error.Abort('lockfile on disk even after releasing!')

        >         testlock.release()

        > EOF

        $ cat >> $HGRCPATH << EOF

        > [extensions]

        > testlock=$TESTTMP/testlock.py

        > EOF

        $ hg -R b testlockexc

        abort: expected release exception

        [255]

      One process waiting for another

        $ cat > hooks.py << EOF

        > import time

        > def sleepone(**x): time.sleep(1)

        > def sleephalf(**x): time.sleep(0.5)

        > EOF

        $ echo b > b/b

        $ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout &

        $ hg -R b up -q --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf" \

        > > preup 2>&1

        $ wait

        $ cat preup

        waiting for lock on working directory of b held by process '*' on host '*' (glob)

        got lock after * seconds (glob)

        $ cat stdout

        adding b

      Pushing to a local read-only repo that can't be locked

        $ chmod 100 a/.hg/store

        $ hg -R b push a

        pushing to a

        searching for changes

        abort: could not lock repository a: Permission denied

        [255]

        $ chmod 700 a/.hg/store

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require unix-permissions no-root no-windows

				Prepare

				$ hg init a
				$ echo a > a/a
				$ hg -R a ci -A -m a
				adding a

				$ hg clone a b
				updating to branch default
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved

				Test that raising an exception in the release function doesn't cause the lock to choke

				$ cat > testlock.py << EOF
				> from mercurial import cmdutil, error, error
				>
				> cmdtable = {}
				> command = cmdutil.command(cmdtable)
				>
				> def acquiretestlock(repo, releaseexc):
				> def unlock():
				> if releaseexc:
				> raise error.Abort('expected release exception')
				> l = repo._lock(repo.vfs, 'testlock', False, unlock, None, 'test lock')
				> return l
				>
				> @command('testlockexc')
				> def testlockexc(ui, repo):
				> testlock = acquiretestlock(repo, True)
				> try:
				> testlock.release()
				> finally:
				> try:
				> testlock = acquiretestlock(repo, False)
				> except error.LockHeld:
				> raise error.Abort('lockfile on disk even after releasing!')
				> testlock.release()
				> EOF
				$ cat >> $HGRCPATH << EOF
				> [extensions]
				> testlock=$TESTTMP/testlock.py
				> EOF

				$ hg -R b testlockexc
				abort: expected release exception
				[255]

				One process waiting for another

				$ cat > hooks.py << EOF
				> import time
				> def sleepone(**x): time.sleep(1)
				> def sleephalf(**x): time.sleep(0.5)
				> EOF
				$ echo b > b/b
				$ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout &
				$ hg -R b up -q --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf" \
				> > preup 2>&1
				$ wait
				$ cat preup
				waiting for lock on working directory of b held by process '' on host '' (glob)
				got lock after * seconds (glob)
				$ cat stdout
				adding b

				Pushing to a local read-only repo that can't be locked

				$ chmod 100 a/.hg/store

				$ hg -R b push a
				pushing to a
				searching for changes
				abort: could not lock repository a: Permission denied
				[255]

				$ chmod 700 a/.hg/store