upstream/mercurial-mirror Files · tests/test-ui-color.py

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Pierre-Yves David - - Load All Authors

File last commit:

r31095:b4cb86ab default


                r32050:77eaf953

4.1.3 stable

Download file

             test-ui-color.py
        
                    40 lines
            
             | 988 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-ui-color.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from __future__ import absolute_import, print_function

      import os

      from hgext import (

          color,

      )

      from mercurial import (

          dispatch,

          ui as uimod,

      )

      # ensure errors aren't buffered

      testui = color.colorui()

      testui.pushbuffer()

      testui.write(('buffered\n'))

      testui.warn(('warning\n'))

      testui.write_err('error\n')

      print(repr(testui.popbuffer()))

      # test dispatch.dispatch with the same ui object

      hgrc = open(os.environ["HGRCPATH"], 'w')

      hgrc.write('[extensions]\n')

      hgrc.write('color=\n')

      hgrc.close()

      ui_ = uimod.ui.load()

      ui_.setconfig('ui', 'formatted', 'True')

      # we're not interested in the output, so write that to devnull

      ui_.fout = open(os.devnull, 'w')

      # call some arbitrary command just so we go through

      # color's wrapped _runcommand twice.

      def runcmd():

          dispatch.dispatch(dispatch.request(['version', '-q'], ui_))

      runcmd()

      print("colored? " + str(issubclass(ui_.__class__, color.colorui)))

      runcmd()

      print("colored? " + str(issubclass(ui_.__class__, color.colorui)))

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from __future__ import absolute_import, print_function

				import os
				from hgext import (
				color,
				)
				from mercurial import (
				dispatch,
				ui as uimod,
				)

				# ensure errors aren't buffered
				testui = color.colorui()
				testui.pushbuffer()
				testui.write(('buffered\n'))
				testui.warn(('warning\n'))
				testui.write_err('error\n')
				print(repr(testui.popbuffer()))

				# test dispatch.dispatch with the same ui object
				hgrc = open(os.environ["HGRCPATH"], 'w')
				hgrc.write('[extensions]\n')
				hgrc.write('color=\n')
				hgrc.close()

				ui_ = uimod.ui.load()
				ui_.setconfig('ui', 'formatted', 'True')

				# we're not interested in the output, so write that to devnull
				ui_.fout = open(os.devnull, 'w')

				# call some arbitrary command just so we go through
				# color's wrapped _runcommand twice.
				def runcmd():
				dispatch.dispatch(dispatch.request(['version', '-q'], ui_))

				runcmd()
				print("colored? " + str(issubclass(ui_.__class__, color.colorui)))
				runcmd()
				print("colored? " + str(issubclass(ui_.__class__, color.colorui)))