upstream/mercurial-mirror Files · tests/test-hghave.t

localrepo: make journal.dirstate contain in-memory changes before transaction...

localrepo: make journal.dirstate contain in-memory changes before transaction Before this patch, in-memory dirstate changes aren't written out at opening transaction, even though 'journal.dirstate' is created directly from '.hg/dirstate'. Therefore, subsequent 'hg rollback' uses incomplete 'undo.dirstate' to restore dirstate, if dirstate is changed and isn't written out before opening transaction. In cases below, the condition "dirstate is changed and isn't written out before opening transaction" isn't satisfied and this problem doesn't appear: - "wlock scope" and "transaction scope" are almost equivalent e.g. 'commit --amend', 'import' and so on - dirstate changes are written out before opening transaction e.g. 'rebase' (via 'dirstateguard') and 'commit -A' (by separated wlock scopes) On the other hand, 'backout' may satisfy the condition above. To make 'journal.dirstate' contain in-memory changes before opening transaction, this patch explicitly invokes 'dirstate.write()' in 'localrepository.transaction()'. 'dirstate.write()' is placed before not "writing journal files out" but "invoking pretxnopen hooks" for visibility of dirstate changes to external hook processes. BTW, in the test script, 'touch -t 200001010000' and 'hg status' are invoked to make file 'c' surely clean in dirstate, because "clean but unsure" files indirectly cause 'dirstate.write()' at 'repo.status()' in 'repo.commit()' (see for detail) and prevents from certainly reproducing the issue.

FUJIWARA Katsunori - - Load All Authors

File last commit:

r25732:b94df10c default


                r25878:800e090e

stable

Download file

             test-hghave.t
        
                    39 lines
            
             | 870 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-hghave.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      Testing that hghave does not crash when checking features

        $ hghave --test-features 2>/dev/null

      Testing hghave extensibility for third party tools

        $ cat > hghaveaddon.py <<EOF

        > import hghave

        > @hghave.check("custom", "custom hghave feature")

        > def has_custom():

        >     return True

        > EOF

      (invocation via run-tests.py)

        $ cat > test-hghaveaddon.t <<EOF

        > #require custom

        >   $ echo foo

        >   foo

        > EOF

        $ run-tests.py test-hghaveaddon.t

        .

        # Ran 1 tests, 0 skipped, 0 warned, 0 failed.

      (invocation via command line)

        $ unset TESTDIR

        $ hghave custom

      (terminate with exit code 2 at failure of importing hghaveaddon.py)

        $ rm hghaveaddon.*

        $ cat > hghaveaddon.py <<EOF

        > importing this file should cause syntax error

        > EOF

        $ hghave custom

        failed to import hghaveaddon.py from '.': invalid syntax (hghaveaddon.py, line 1)

        [2]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				Testing that hghave does not crash when checking features

				$ hghave --test-features 2>/dev/null

				Testing hghave extensibility for third party tools

				$ cat > hghaveaddon.py <<EOF
				> import hghave
				> @hghave.check("custom", "custom hghave feature")
				> def has_custom():
				> return True
				> EOF

				(invocation via run-tests.py)

				$ cat > test-hghaveaddon.t <<EOF
				> #require custom
				> $ echo foo
				> foo
				> EOF
				$ run-tests.py test-hghaveaddon.t
				.
				# Ran 1 tests, 0 skipped, 0 warned, 0 failed.

				(invocation via command line)

				$ unset TESTDIR
				$ hghave custom

				(terminate with exit code 2 at failure of importing hghaveaddon.py)

				$ rm hghaveaddon.*
				$ cat > hghaveaddon.py <<EOF
				> importing this file should cause syntax error
				> EOF

				$ hghave custom
				failed to import hghaveaddon.py from '.': invalid syntax (hghaveaddon.py, line 1)
				[2]