upstream/mercurial-mirror Files · mercurial/utils/repoviewutil.py

exchange: improve computation of relevant markers for large repos...

exchange: improve computation of relevant markers for large repos Compute the candidate nodes with relevant markers directly from keys of the predecessors/successors/children dictionaries of obsstore. This is faster than iterating over all nodes directly. This test could be further improved for repositories with relative few markers compared to the repository size, but this is no longer hot already. With the current loop structure, the obshashrange use works as well as before as it passes lists with a single node. Adjust the interface by allowing revision lists as well as node lists. This helps cases that computes ancestors as it reduces the materialisation cost. Use this in _pushdiscoveryobsmarker and _getbundleobsmarkerpart. Improve the latter further by directly using ancestors(). Performance benchmarks show notable and welcome improvement to no-op push and pull (that would also apply to other push/pull). This apply to push and pull done without evolve. ### push/pull Benchmark parameter # bin-env-vars.hg.flavor = default # benchmark.variants.explicit-rev = none # benchmark.variants.protocol = ssh # benchmark.variants.revs = none ## benchmark.name = hg.command.pull # data-env-vars.name = mercurial-devel-2024-03-22-zstd-sparse-revlog before: 5.968537 seconds after: 5.668507 seconds (-5.03%, -0.30) # data-env-vars.name = tryton-devel-2024-03-22-zstd-sparse-revlog before: 1.446232 seconds after: 0.835553 seconds (-42.23%, -0.61) # data-env-vars.name = netbsd-src-draft-2024-09-19-zstd-sparse-revlog before: 5.777412 seconds after: 2.523454 seconds (-56.32%, -3.25) ## benchmark.name = hg.command.push # data-env-vars.name = mercurial-devel-2024-03-22-zstd-sparse-revlog before: 6.155501 seconds after: 5.885072 seconds (-4.39%, -0.27) # data-env-vars.name = tryton-devel-2024-03-22-zstd-sparse-revlog before: 1.491054 seconds after: 0.934882 seconds (-37.30%, -0.56) # data-env-vars.name = netbsd-src-draft-2024-09-19-zstd-sparse-revlog before: 5.902494 seconds after: 2.957644 seconds (-49.89%, -2.94) There is not notable different in these result using the "rust" flavor instead of the "default". The performance impact on the same operation when using evolve were also tested and no impact was noted.

Matt Harbison - - Load All Authors

File last commit:

r52756:f4733654 default


                r52789:8583d138

default

Download file

             repoviewutil.py
        
                    53 lines
            
             | 1.6 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / utils / repoviewutil.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # repoviewutil.py - constaints data relevant to repoview.py and other module

      #

      # Copyright 2012 Pierre-Yves David <pierre-yves.david@ens-lyon.org>

      #                Logilab SA        <contact@logilab.fr>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import annotations

      from .. import error

      ### Nearest subset relation

      # Nearest subset of filter X is a filter Y so that:

      # * Y is included in X,

      # * X - Y is as small as possible.

      # This create and ordering used for branchmap purpose.

      # the ordering may be partial

      subsettable = {

          None: b'visible',

          b'visible-hidden': b'visible',

          b'visible': b'served',

          b'served.hidden': b'served',

          b'served': b'immutable',

          b'immutable': b'base',

      }

      def get_ordered_subset():

          """return a list of subset name from dependencies to dependents"""

          _unfinalized = set(subsettable.values())

          ordered = []

          # the subset table is expected to be small so we do the stupid N² version

          # of the algorithm

          while _unfinalized:

              this_level = []

              for candidate in _unfinalized:

                  dependency = subsettable.get(candidate)

                  if dependency not in _unfinalized:

                      this_level.append(candidate)

              if not this_level:

                  msg = "cyclic dependencies in repoview subset %r"

                  msg %= subsettable

                  raise error.ProgrammingError(msg)

              this_level.sort(key=lambda x: x if x is not None else '')

              ordered.extend(this_level)

              _unfinalized.difference_update(this_level)

          return ordered

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# repoviewutil.py - constaints data relevant to repoview.py and other module
				#
				# Copyright 2012 Pierre-Yves David <pierre-yves.david@ens-lyon.org>
				# Logilab SA <contact@logilab.fr>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import annotations

				from .. import error

				### Nearest subset relation
				# Nearest subset of filter X is a filter Y so that:
				# * Y is included in X,
				# * X - Y is as small as possible.
				# This create and ordering used for branchmap purpose.
				# the ordering may be partial
				subsettable = {
				None: b'visible',
				b'visible-hidden': b'visible',
				b'visible': b'served',
				b'served.hidden': b'served',
				b'served': b'immutable',
				b'immutable': b'base',
				}


				def get_ordered_subset():
				"""return a list of subset name from dependencies to dependents"""
				_unfinalized = set(subsettable.values())
				ordered = []

				# the subset table is expected to be small so we do the stupid N² version
				# of the algorithm
				while _unfinalized:
				this_level = []
				for candidate in _unfinalized:
				dependency = subsettable.get(candidate)
				if dependency not in _unfinalized:
				this_level.append(candidate)

				if not this_level:
				msg = "cyclic dependencies in repoview subset %r"
				msg %= subsettable
				raise error.ProgrammingError(msg)

				this_level.sort(key=lambda x: x if x is not None else '')

				ordered.extend(this_level)
				_unfinalized.difference_update(this_level)

				return ordered