upstream/mercurial-mirror Files · mercurial/pure/osutil.py

patch: deprecate ui.patch / external patcher feature...

patch: deprecate ui.patch / external patcher feature Why? - Mercurial internal patcher works correctly for regular patches and git patches, is much faster at least on Windows and is more extensible. - In theory, the external patcher can be used to handle exotic patch formats. I do not know any and have not heard about any such use in years. - Most patch programs cannot handle git format patches, which makes the API caller to decide either to ignore ui.patch by calling patch.internalpatch() directly, or take the risk of random failures with valid inputs. - One thing a patch program could do Mercurial patcher cannot is applying with --reverse. Apparently several shelve like extensions try to use that, including passing the "reverse" option to Mercurial patcher, which has been removed mid-2009. I never heard anybody complain about that, and would prefer reimplementing it anyway. And from the technical perspective: - The external patcher makes everything harder to maintain and implement. EOL normalization is not implemented, and I would bet file renames, if supported by the patcher, are not correctly recorded in the dirstate. - No tests. How? - Remove related documentation - Clearly mark patch.externalpatch() as private - Remove the debuginstall check. This deprecation request was actually triggered by this last point. debuginstall is the only piece of code patching without a repository. When migrating to an integrated patch() + updatedir() call, this was really a showstopper, all workarounds were either ugly or uselessly complicated to implement. If we do not support external patcher anymore, the debuginstall check is not useful anymore. - Remove patch.externalpatch() after 1.9 release.

Benoit Boissinot - - Load All Authors

File last commit:

r10651:5f091fc1 default


                r13751:85d74f6b

default

Download file

             osutil.py
        
                    59 lines
            
             | 1.5 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / pure / osutil.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # osutil.py - pure Python version of osutil.c

      #

      #  Copyright 2009 Matt Mackall <mpm@selenic.com> and others

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      import os

      import stat as statmod

      posixfile = open

      def _mode_to_kind(mode):

          if statmod.S_ISREG(mode):

              return statmod.S_IFREG

          if statmod.S_ISDIR(mode):

              return statmod.S_IFDIR

          if statmod.S_ISLNK(mode):

              return statmod.S_IFLNK

          if statmod.S_ISBLK(mode):

              return statmod.S_IFBLK

          if statmod.S_ISCHR(mode):

              return statmod.S_IFCHR

          if statmod.S_ISFIFO(mode):

              return statmod.S_IFIFO

          if statmod.S_ISSOCK(mode):

              return statmod.S_IFSOCK

          return mode

      def listdir(path, stat=False, skip=None):

          '''listdir(path, stat=False) -> list_of_tuples

          Return a sorted list containing information about the entries

          in the directory.

          If stat is True, each element is a 3-tuple:

            (name, type, stat object)

          Otherwise, each element is a 2-tuple:

            (name, type)

          '''

          result = []

          prefix = path

          if not prefix.endswith(os.sep):

              prefix += os.sep

          names = os.listdir(path)

          names.sort()

          for fn in names:

              st = os.lstat(prefix + fn)

              if fn == skip and statmod.S_ISDIR(st.st_mode):

                  return []

              if stat:

                  result.append((fn, _mode_to_kind(st.st_mode), st))

              else:

                  result.append((fn, _mode_to_kind(st.st_mode)))

          return result

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# osutil.py - pure Python version of osutil.c
				#
				# Copyright 2009 Matt Mackall <mpm@selenic.com> and others
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				import os
				import stat as statmod

				posixfile = open

				def _mode_to_kind(mode):
				if statmod.S_ISREG(mode):
				return statmod.S_IFREG
				if statmod.S_ISDIR(mode):
				return statmod.S_IFDIR
				if statmod.S_ISLNK(mode):
				return statmod.S_IFLNK
				if statmod.S_ISBLK(mode):
				return statmod.S_IFBLK
				if statmod.S_ISCHR(mode):
				return statmod.S_IFCHR
				if statmod.S_ISFIFO(mode):
				return statmod.S_IFIFO
				if statmod.S_ISSOCK(mode):
				return statmod.S_IFSOCK
				return mode

				def listdir(path, stat=False, skip=None):
				'''listdir(path, stat=False) -> list_of_tuples

				Return a sorted list containing information about the entries
				in the directory.

				If stat is True, each element is a 3-tuple:

				(name, type, stat object)

				Otherwise, each element is a 2-tuple:

				(name, type)
				'''
				result = []
				prefix = path
				if not prefix.endswith(os.sep):
				prefix += os.sep
				names = os.listdir(path)
				names.sort()
				for fn in names:
				st = os.lstat(prefix + fn)
				if fn == skip and statmod.S_ISDIR(st.st_mode):
				return []
				if stat:
				result.append((fn, _mode_to_kind(st.st_mode), st))
				else:
				result.append((fn, _mode_to_kind(st.st_mode)))
				return result