##// END OF EJS Templates
worker: use os._exit for posix worker in all cases...
worker: use os._exit for posix worker in all cases Like commandserver, the worker should never run other resource cleanup logic. Previously this is not true for workers if they have exceptions other than KeyboardInterrupt. This actually caused a real-world deadlock with remotefilelog: 1. remotefilelog/fileserverclient creates a sshpeer. pipei/o/e get created. 2. worker inherits that sshpeer's pipei/o/e. 3. worker runs sshpeer.cleanup (only happens without os._exit) 4. worker closes pipeo/i, which will normally make the sshpeer read EOF from its stdin and exit. But the master process still have pipeo, so no EOF. 5. worker reads pipee (stderr of sshpeer), which never completes because the ssh process does not exit, does not close its stderr. 6. master waits for all workers, which never completes because they never complete sshpeer.cleanup. This could also be addressed by closing these fds after fork, which is not easy because Python 2.x does not have an official "afterfork" hook. Hacking os.fork is also ugly. Besides, sshpeer is probably not the only troublemarker. The patch changes _posixworker so all its code paths will use os._exit to avoid running unwanted resource clean-ups.
Jun Wu -
r30521:86cd09bc default
Show More
Name Size Modified Last Commit Author
/ hgext / largefiles
CONTRIBUTORS Loading ...
__init__.py Loading ...
basestore.py Loading ...
lfcommands.py Loading ...
lfutil.py Loading ...
localstore.py Loading ...
overrides.py Loading ...
proto.py Loading ...
remotestore.py Loading ...
reposetup.py Loading ...
storefactory.py Loading ...
uisetup.py Loading ...
wirestore.py Loading ...