upstream/mercurial-mirror Files · hgext/remotefilelog/shallowstore.py

lock: pass "success" boolean to _afterlock callbacks...

lock: pass "success" boolean to _afterlock callbacks This lets the callback decide if it should actually run or not. I suspect that most callbacks (and hooks) *should not* run in this scenario, but I'm trying to not break any existing behavior. `persistmanifestcache`, however, seems actively dangerous to run: we just encountered an exception and the repo is in an unknown state (hopefully a consistent one due to transactions, but this is not 100% guaranteed), and the data we cache may be based on this unknown state. This was observed by our users since we wrap some of the functions that persistmanifestcache calls and it expects that the repo object is in a certain state that we'd set up earlier. If the user hits ctrl-c before we establish that state, we end up crashing there. I'm going to make that extension resilient to this issue, but figured it might be a common issue and should be handled here as well instead of just working around the issue. Differential Revision: https://phab.mercurial-scm.org/D7459

Augie Fackler - - Load All Authors

File last commit:

r43346:2372284d default


                r44217:888bd39e

default

Download file

             shallowstore.py
        
                    18 lines
            
             | 491 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / remotefilelog / shallowstore.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # shallowstore.py - shallow store for interacting with shallow repos

      #

      # Copyright 2013 Facebook, Inc.

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      def wrapstore(store):

          class shallowstore(store.__class__):

              def __contains__(self, path):

                  # Assume it exists

                  return True

          store.__class__ = shallowstore

          return store

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# shallowstore.py - shallow store for interacting with shallow repos
				#
				# Copyright 2013 Facebook, Inc.
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.
				from __future__ import absolute_import


				def wrapstore(store):
				class shallowstore(store.__class__):
				def __contains__(self, path):
				# Assume it exists
				return True

				store.__class__ = shallowstore

				return store