upstream/mercurial-mirror Files · mercurial/txnutil.py

revert: remove dangerous `parents` argument from `cmdutil.revert()`...

revert: remove dangerous `parents` argument from `cmdutil.revert()` As we found out the hard way (thanks to spectral@ for figuring it out!), `cmdutil.revert()`'s `parents` argument must be `repo.dirstate.parents()` or things may go wrong. We had an extension that passed in the target commit as the first parent. The `hg split` command from the evolve extension seems to have made the same mistake, but I haven't looked carefully. The problem is that `cmdutil._performrevert()` calls `dirstate.normal()` on reverted files if the commit to revert to equals the first parent. So if you pass in `ctx=foo` and `parents=(foo.node(), nullid)`, then `dirstate.normal()` will be called for the revert files, even though they might not be clean in the working copy. There doesn't seem to be any reason, other than a tiny performance benefit, to passing the `parents` around instead of looking them up again in `cmdutil._performrevert()`, so that's what this patch does. Differential Revision: https://phab.mercurial-scm.org/D8925

Augie Fackler - - Load All Authors

File last commit:

r43347:687b865b default


                r45935:8c466bcb

default

Download file

             txnutil.py
        
                    36 lines
            
             | 1.0 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / txnutil.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # txnutil.py - transaction related utilities

      #

      #  Copyright FUJIWARA Katsunori <foozy@lares.dti.ne.jp> and others

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      import errno

      from . import encoding

      def mayhavepending(root):

          '''return whether 'root' may have pending changes, which are

          visible to this process.

          '''

          return root == encoding.environ.get(b'HG_PENDING')

      def trypending(root, vfs, filename, **kwargs):

          '''Open  file to be read according to HG_PENDING environment variable

          This opens '.pending' of specified 'filename' only when HG_PENDING

          is equal to 'root'.

          This returns '(fp, is_pending_opened)' tuple.

          '''

          if mayhavepending(root):

              try:

                  return (vfs(b'%s.pending' % filename, **kwargs), True)

              except IOError as inst:

                  if inst.errno != errno.ENOENT:

                      raise

          return (vfs(filename, **kwargs), False)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# txnutil.py - transaction related utilities
				#
				# Copyright FUJIWARA Katsunori <foozy@lares.dti.ne.jp> and others
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import absolute_import

				import errno

				from . import encoding


				def mayhavepending(root):
				'''return whether 'root' may have pending changes, which are
				visible to this process.
				'''
				return root == encoding.environ.get(b'HG_PENDING')


				def trypending(root, vfs, filename, **kwargs):
				'''Open file to be read according to HG_PENDING environment variable

				This opens '.pending' of specified 'filename' only when HG_PENDING
				is equal to 'root'.

				This returns '(fp, is_pending_opened)' tuple.
				'''
				if mayhavepending(root):
				try:
				return (vfs(b'%s.pending' % filename, **kwargs), True)
				except IOError as inst:
				if inst.errno != errno.ENOENT:
				raise
				return (vfs(filename, **kwargs), False)