upstream/mercurial-mirror Files · mercurial/stack.py

localrepo: do not cache auditor/nofsauditor which would make reference cycle...

localrepo: do not cache auditor/nofsauditor which would make reference cycle Before, self.auditor and self.nofsauditor held self through self._checknested, and the following code couldn't free a repo by ref-counting. def main(): repo = localrepo.localrepository(uimod.ui(), '../testrepos/hello') main() With this change, the cache of the nofsauditor is limited to a single match session. I think that's okay as the nofsauditor doesn't do any filesystem access. Alternatively, maybe we can remove the callback from nofsauditor since it isn't used unless realfs=True, but I have no idea whether it is a bug or not.

Boris Feld - - Load All Authors

File last commit:

r37022:68fcc550 default


                r39348:9198e41d

default

Download file

             stack.py
        
                    29 lines
            
             | 869 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / stack.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # stack.py - Mercurial functions for stack definition

      #

      #  Copyright Matt Mackall <mpm@selenic.com> and other

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      from . import (

          revsetlang,

          scmutil,

      )

      def getstack(repo, rev=None):

          """return a sorted smartrev of the stack containing either rev if it is

          not None or the current working directory parent.

          The stack will always contain all drafts changesets which are ancestors to

          the revision and are not merges.

          """

          if rev is None:

              rev = '.'

          revspec = 'reverse(only(%s) and not public() and not ::merge())'

          revset = revsetlang.formatspec(revspec, rev)

          revisions = scmutil.revrange(repo, [revset])

          revisions.sort()

          return revisions

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# stack.py - Mercurial functions for stack definition
				#
				# Copyright Matt Mackall <mpm@selenic.com> and other
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import absolute_import

				from . import (
				revsetlang,
				scmutil,
				)

				def getstack(repo, rev=None):
				"""return a sorted smartrev of the stack containing either rev if it is
				not None or the current working directory parent.

				The stack will always contain all drafts changesets which are ancestors to
				the revision and are not merges.
				"""
				if rev is None:
				rev = '.'

				revspec = 'reverse(only(%s) and not public() and not ::merge())'
				revset = revsetlang.formatspec(revspec, rev)
				revisions = scmutil.revrange(repo, [revset])
				revisions.sort()
				return revisions