upstream/mercurial-mirror Files · hgext/hooklib/reject_new_heads.py

phabricator: pass old `fctx` to `addoldbinary()` instead of inferring it...

phabricator: pass old `fctx` to `addoldbinary()` instead of inferring it Currently, removed binaries aren't marked as binaries on the left side, which sends the raw file view to a bad URL in the web interface. (See D8009) In order to handle marking the file as binary in the removed case, both contexts need to be provided by the caller, since there is no current fctx in the removed case. Having an explicit old fctx will also be useful to support a `--no-stack` option that rolls up the commit stack into a single review. The bug isn't fixed with this change- there's a missing call to it in `addremoved()` as well. But instead of spamming the list with a bunch of test diffs, all of the missing binary issues will be fixed at once later. Differential Revision: https://phab.mercurial-scm.org/D8218

Joerg Sonnenberger - - Load All Authors

File last commit:

r44897:4cabeea6 default


                r44911:98f7b9cf

default

Download file

             reject_new_heads.py
        
                    41 lines
            
             | 1.2 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / hooklib / reject_new_heads.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Copyright 2020 Joerg Sonnenberger <joerg@bec.de>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      """reject_new_heads is a hook to check that branches touched by new changesets

      have at most one open head. It can be used to enforce policies for

      merge-before-push or rebase-before-push. It does not handle pre-existing

      hydras.

      Usage:

        [hooks]

        pretxnclose.reject_new_heads = \

          python:hgext.hooklib.reject_new_heads.hook

      """

      from __future__ import absolute_import

      from mercurial.i18n import _

      from mercurial import (

          error,

          pycompat,

      )

      def hook(ui, repo, hooktype, node=None, **kwargs):

          if hooktype != b"pretxnclose":

              raise error.Abort(

                  _(b'Unsupported hook type %r') % pycompat.bytestr(hooktype)

              )

          ctx = repo.unfiltered()[node]

          branches = set()

          for rev in repo.changelog.revs(start=ctx.rev()):

              rev = repo[rev]

              branches.add(rev.branch())

          for branch in branches:

              if len(repo.revs("head() and not closed() and branch(%s)", branch)) > 1:

                  raise error.Abort(

                      _(b'Changes on branch %r resulted in multiple heads')

                      % pycompat.bytestr(branch)

                  )

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Copyright 2020 Joerg Sonnenberger <joerg@bec.de>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				"""reject_new_heads is a hook to check that branches touched by new changesets
				have at most one open head. It can be used to enforce policies for
				merge-before-push or rebase-before-push. It does not handle pre-existing
				hydras.

				Usage:
				[hooks]
				pretxnclose.reject_new_heads = \
				python:hgext.hooklib.reject_new_heads.hook
				"""

				from __future__ import absolute_import

				from mercurial.i18n import _
				from mercurial import (
				error,
				pycompat,
				)


				def hook(ui, repo, hooktype, node=None, **kwargs):
				if hooktype != b"pretxnclose":
				raise error.Abort(
				_(b'Unsupported hook type %r') % pycompat.bytestr(hooktype)
				)
				ctx = repo.unfiltered()[node]
				branches = set()
				for rev in repo.changelog.revs(start=ctx.rev()):
				rev = repo[rev]
				branches.add(rev.branch())
				for branch in branches:
				if len(repo.revs("head() and not closed() and branch(%s)", branch)) > 1:
				raise error.Abort(
				_(b'Changes on branch %r resulted in multiple heads')
				% pycompat.bytestr(branch)
				)