upstream/mercurial-mirror Files · mercurial/templates/paper/index.tmpl

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Thomas Arendsen Hein - - Load All Authors

File last commit:

r18526:9409aeaa stable


                r18759:9baf4330

default

Download file

             index.tmpl
        
                    27 lines
            
             | 728 B
            
                | application/x-cheetah
            
             |
                CheetahLexer
            
             / mercurial / templates / paper / index.tmpl
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      {header}

      <title>Mercurial repositories index</title>

      </head>

      <body>

      <div class="container">

      <div class="menu">

      <a href="{logourl}">

      <img src="{staticurl|urlescape}{logoimg}" width=75 height=90 border=0 alt="mercurial" /></a>

      </div>

      <div class="main">

      <h2 class="breadcrumb"><a href="/">Mercurial</a> {pathdef%breadcrumb}</h2>

      <table class="bigtable">

          <tr>

              <th><a href="?sort={sort_name}">Name</a></th>

              <th><a href="?sort={sort_description}">Description</a></th>

              <th><a href="?sort={sort_contact}">Contact</a></th>

              <th><a href="?sort={sort_lastchange}">Last modified</a></th>

              <th>&nbsp;</th>

              <th>&nbsp;</th>

          </tr>

          {entries%indexentry}

      </table>

      </div>

      </div>

      {footer}

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				{header}
				<title>Mercurial repositories index</title>
				</head>
				<body>

				<div class="container">
				<div class="menu">
				<a href="{logourl}">
				<img src="{staticurl\|urlescape}{logoimg}" width=75 height=90 border=0 alt="mercurial" /></a>
				</div>
				<div class="main">
				<h2 class="breadcrumb"><a href="/">Mercurial</a> {pathdef%breadcrumb}</h2>

				<table class="bigtable">
				<tr>
				<th><a href="?sort={sort_name}">Name</a></th>
				<th><a href="?sort={sort_description}">Description</a></th>
				<th><a href="?sort={sort_contact}">Contact</a></th>
				<th><a href="?sort={sort_lastchange}">Last modified</a></th>
				<th> </th>
				<th> </th>
				</tr>
				{entries%indexentry}
				</table>
				</div>
				</div>
				{footer}