upstream/mercurial-mirror Files · mercurial/templates/spartan/manifest.tmpl

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Thomas Arendsen Hein - - Load All Authors

File last commit:

r18526:9409aeaa stable


                r18759:9baf4330

default

Download file

             manifest.tmpl
        
                    29 lines
            
             | 1.1 KiB
            
                | application/x-cheetah
            
             |
                CheetahLexer
            
             / mercurial / templates / spartan / manifest.tmpl
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      {header}

      <title>{repo|escape}: files for changeset {node|short}</title>

      </head>

      <body>

      <div class="buttons">

      <a href="{url|urlescape}log/{rev}{sessionvars%urlparameter}">changelog</a>

      <a href="{url|urlescape}shortlog/{rev}{sessionvars%urlparameter}">shortlog</a>

      <a href="{url|urlescape}graph{sessionvars%urlparameter}">graph</a>

      <a href="{url|urlescape}tags{sessionvars%urlparameter}">tags</a>

      <a href="{url|urlescape}branches{sessionvars%urlparameter}">branches</a>

      <a href="{url|urlescape}rev/{node|short}{sessionvars%urlparameter}">changeset</a>

      {archives%archiveentry}

      <a href="{url|urlescape}help{sessionvars%urlparameter}">help</a>

      </div>

      <h2><a href="/">Mercurial</a> {pathdef%breadcrumb} / files for changeset <a href="{url|urlescape}rev/{node|short}">{node|short}</a>: {path|escape}</h2>

      <table cellpadding="0" cellspacing="0">

      <tr class="parity{upparity}">

        <td><tt>drwxr-xr-x</tt>&nbsp;

        <td>&nbsp;

        <td>&nbsp;

        <td><a href="{url|urlescape}file/{node|short}{up|urlescape}{sessionvars%urlparameter}">[up]</a>

      </tr>

      {dentries%direntry}

      {fentries%fileentry}

      </table>

      {footer}

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				{header}
				<title>{repo\|escape}: files for changeset {node\|short}</title>
				</head>
				<body>

				<div class="buttons">
				<a href="{url\|urlescape}log/{rev}{sessionvars%urlparameter}">changelog</a>
				<a href="{url\|urlescape}shortlog/{rev}{sessionvars%urlparameter}">shortlog</a>
				<a href="{url\|urlescape}graph{sessionvars%urlparameter}">graph</a>
				<a href="{url\|urlescape}tags{sessionvars%urlparameter}">tags</a>
				<a href="{url\|urlescape}branches{sessionvars%urlparameter}">branches</a>
				<a href="{url\|urlescape}rev/{node\|short}{sessionvars%urlparameter}">changeset</a>
				{archives%archiveentry}
				<a href="{url\|urlescape}help{sessionvars%urlparameter}">help</a>
				</div>

				<h2><a href="/">Mercurial</a> {pathdef%breadcrumb} / files for changeset <a href="{url\|urlescape}rev/{node\|short}">{node\|short}</a>: {path\|escape}</h2>

				<table cellpadding="0" cellspacing="0">
				<tr class="parity{upparity}">
				<td><tt>drwxr-xr-x</tt>
				<td>
				<td>
				<td><a href="{url\|urlescape}file/{node\|short}{up\|urlescape}{sessionvars%urlparameter}">[up]</a>
				</tr>
				{dentries%direntry}
				{fentries%fileentry}
				</table>
				{footer}