upstream/mercurial-mirror Files · tests/autodiff.py

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Matt Mackall - - Load All Authors

File last commit:

r17956:a08775ec default


                r18759:9baf4330

default

Download file

             autodiff.py
        
                    46 lines
            
             | 1.3 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / autodiff.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Extension dedicated to test patch.diff() upgrade modes

      #

      #

      from mercurial import scmutil, patch, util

      def autodiff(ui, repo, *pats, **opts):

          diffopts = patch.diffopts(ui, opts)

          git = opts.get('git', 'no')

          brokenfiles = set()

          losedatafn = None

          if git in ('yes', 'no'):

              diffopts.git = git == 'yes'

              diffopts.upgrade = False

          elif git == 'auto':

              diffopts.git = False

              diffopts.upgrade = True

          elif git == 'warn':

              diffopts.git = False

              diffopts.upgrade = True

              def losedatafn(fn=None, **kwargs):

                  brokenfiles.add(fn)

                  return True

          elif git == 'abort':

              diffopts.git = False

              diffopts.upgrade = True

              def losedatafn(fn=None, **kwargs):

                  raise util.Abort('losing data for %s' % fn)

          else:

              raise util.Abort('--git must be yes, no or auto')

          node1, node2 = scmutil.revpair(repo, [])

          m = scmutil.match(repo[node2], pats, opts)

          it = patch.diff(repo, node1, node2, match=m, opts=diffopts,

                          losedatafn=losedatafn)

          for chunk in it:

              ui.write(chunk)

          for fn in sorted(brokenfiles):

              ui.write(('data lost for: %s\n' % fn))

      cmdtable = {

          "autodiff":

              (autodiff,

               [('', 'git', '', 'git upgrade mode (yes/no/auto/warn/abort)'),

                ],

               '[OPTION]... [FILE]...'),

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Extension dedicated to test patch.diff() upgrade modes
				#
				#
				from mercurial import scmutil, patch, util

				def autodiff(ui, repo, pats, *opts):
				diffopts = patch.diffopts(ui, opts)
				git = opts.get('git', 'no')
				brokenfiles = set()
				losedatafn = None
				if git in ('yes', 'no'):
				diffopts.git = git == 'yes'
				diffopts.upgrade = False
				elif git == 'auto':
				diffopts.git = False
				diffopts.upgrade = True
				elif git == 'warn':
				diffopts.git = False
				diffopts.upgrade = True
				def losedatafn(fn=None, **kwargs):
				brokenfiles.add(fn)
				return True
				elif git == 'abort':
				diffopts.git = False
				diffopts.upgrade = True
				def losedatafn(fn=None, **kwargs):
				raise util.Abort('losing data for %s' % fn)
				else:
				raise util.Abort('--git must be yes, no or auto')

				node1, node2 = scmutil.revpair(repo, [])
				m = scmutil.match(repo[node2], pats, opts)
				it = patch.diff(repo, node1, node2, match=m, opts=diffopts,
				losedatafn=losedatafn)
				for chunk in it:
				ui.write(chunk)
				for fn in sorted(brokenfiles):
				ui.write(('data lost for: %s\n' % fn))

				cmdtable = {
				"autodiff":
				(autodiff,
				[('', 'git', '', 'git upgrade mode (yes/no/auto/warn/abort)'),
				],
				'[OPTION]... [FILE]...'),
				}