upstream/mercurial-mirror Files · tests/filterpyflakes.py

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Augie Fackler - - Load All Authors

File last commit:

r14209:08d84bdc default


                r18759:9baf4330

default

Download file

             filterpyflakes.py
        
                    38 lines
            
             | 1.0 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / filterpyflakes.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/usr/bin/env python

      # Filter output by pyflakes to control which warnings we check

      import sys, re, os

      def makekey(message):

          # "path/file:line: message"

          match = re.search(r"(line \d+)", message)

          line = ''

          if match:

              line = match.group(0)

              message = re.sub(r"(line \d+)", '', message)

          return re.sub(r"([^:]*):([^:]+):([^']*)('[^']*')(.*)$",

                        r'\3:\5:\4:\1:\2:' + line,

                        message)

      lines = []

      for line in sys.stdin:

          # We whitelist tests

          pats = [

                  r"imported but unused",

                  r"local variable '.*' is assigned to but never used",

                  r"unable to detect undefined names",

                 ]

          if not re.search('|'.join(pats), line):

              continue

          fn = line.split(':', 1)[0]

          f = open(os.path.join(os.path.dirname(os.path.dirname(__file__)), fn))

          data = f.read()

          f.close()

          if 'no-check-code' in data:

              continue

          lines.append(line)

      for line in sorted(lines, key = makekey):

          sys.stdout.write(line)

      print

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/usr/bin/env python

				# Filter output by pyflakes to control which warnings we check

				import sys, re, os

				def makekey(message):
				# "path/file:line: message"
				match = re.search(r"(line \d+)", message)
				line = ''
				if match:
				line = match.group(0)
				message = re.sub(r"(line \d+)", '', message)
				return re.sub(r"([^:]):([^:]+):([^'])('[^']')(.)$",
				r'\3:\5:\4:\1:\2:' + line,
				message)

				lines = []
				for line in sys.stdin:
				# We whitelist tests
				pats = [
				r"imported but unused",
				r"local variable '.*' is assigned to but never used",
				r"unable to detect undefined names",
				]
				if not re.search('\|'.join(pats), line):
				continue
				fn = line.split(':', 1)[0]
				f = open(os.path.join(os.path.dirname(os.path.dirname(__file__)), fn))
				data = f.read()
				f.close()
				if 'no-check-code' in data:
				continue
				lines.append(line)

				for line in sorted(lines, key = makekey):
				sys.stdout.write(line)
				print