upstream/mercurial-mirror Files · tests/md5sum.py

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Martin Geisler - - Load All Authors

File last commit:

r14494:1ffeeb91 default


                r18759:9baf4330

default

Download file

             md5sum.py
        
                    42 lines
            
             | 995 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / md5sum.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/usr/bin/env python

      #

      # Based on python's Tools/scripts/md5sum.py

      #

      # This software may be used and distributed according to the terms

      # of the PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2, which is

      # GPL-compatible.

      import sys, os

      try:

          from hashlib import md5

      except ImportError:

          from md5 import md5

      try:

          import msvcrt

          msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)

          msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY)

      except ImportError:

          pass

      for filename in sys.argv[1:]:

          try:

              fp = open(filename, 'rb')

          except IOError, msg:

              sys.stderr.write('%s: Can\'t open: %s\n' % (filename, msg))

              sys.exit(1)

          m = md5()

          try:

              while True:

                  data = fp.read(8192)

                  if not data:

                      break

                  m.update(data)

          except IOError, msg:

              sys.stderr.write('%s: I/O error: %s\n' % (filename, msg))

              sys.exit(1)

          sys.stdout.write('%s  %s\n' % (m.hexdigest(), filename))

      sys.exit(0)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/usr/bin/env python
				#
				# Based on python's Tools/scripts/md5sum.py
				#
				# This software may be used and distributed according to the terms
				# of the PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2, which is
				# GPL-compatible.

				import sys, os

				try:
				from hashlib import md5
				except ImportError:
				from md5 import md5

				try:
				import msvcrt
				msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)
				msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY)
				except ImportError:
				pass

				for filename in sys.argv[1:]:
				try:
				fp = open(filename, 'rb')
				except IOError, msg:
				sys.stderr.write('%s: Can\'t open: %s\n' % (filename, msg))
				sys.exit(1)

				m = md5()
				try:
				while True:
				data = fp.read(8192)
				if not data:
				break
				m.update(data)
				except IOError, msg:
				sys.stderr.write('%s: I/O error: %s\n' % (filename, msg))
				sys.exit(1)
				sys.stdout.write('%s %s\n' % (m.hexdigest(), filename))

				sys.exit(0)