upstream/mercurial-mirror Files · tests/readlink.py

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Matt Mackall - - Load All Authors

File last commit:

r10282:08a0f04b default


                r18759:9baf4330

default

Download file

             readlink.py
        
                    13 lines
            
             | 243 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / readlink.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/usr/bin/env python

      import errno, os, sys

      for f in sys.argv[1:]:

          try:

              print f, '->', os.readlink(f)

          except OSError, err:

              if err.errno != errno.EINVAL:

                  raise

              print f, 'not a symlink'

      sys.exit(0)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/usr/bin/env python

				import errno, os, sys

				for f in sys.argv[1:]:
				try:
				print f, '->', os.readlink(f)
				except OSError, err:
				if err.errno != errno.EINVAL:
				raise
				print f, 'not a symlink'

				sys.exit(0)