upstream/mercurial-mirror Files · tests/test-conflict.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Matt Mackall - - Load All Authors

File last commit:

r15501:2371f4ae default


                r18759:9baf4330

default

Download file

             test-conflict.t
        
                    33 lines
            
             | 732 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-conflict.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init

        $ echo "nothing" > a

        $ hg add a

        $ hg commit -m ancestor

        $ echo "something" > a

        $ hg commit -m branch1

        $ hg co 0

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ echo "something else" > a

        $ hg commit -m branch2

        created new head

        $ hg merge 1

        merging a

        warning: conflicts during merge.

        merging a incomplete! (edit conflicts, then use 'hg resolve --mark')

        0 files updated, 0 files merged, 0 files removed, 1 files unresolved

        use 'hg resolve' to retry unresolved file merges or 'hg update -C .' to abandon

        [1]

        $ hg id

        32e80765d7fe+75234512624c+ tip

        $ cat a

        <<<<<<< local

        something else

        =======

        something

        >>>>>>> other

        $ hg status

        M a

        ? a.orig

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init
				$ echo "nothing" > a
				$ hg add a
				$ hg commit -m ancestor
				$ echo "something" > a
				$ hg commit -m branch1
				$ hg co 0
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ echo "something else" > a
				$ hg commit -m branch2
				created new head

				$ hg merge 1
				merging a
				warning: conflicts during merge.
				merging a incomplete! (edit conflicts, then use 'hg resolve --mark')
				0 files updated, 0 files merged, 0 files removed, 1 files unresolved
				use 'hg resolve' to retry unresolved file merges or 'hg update -C .' to abandon
				[1]

				$ hg id
				32e80765d7fe+75234512624c+ tip

				$ cat a
				<<<<<<< local
				something else
				=======
				something
				>>>>>>> other

				$ hg status
				M a
				? a.orig