upstream/mercurial-mirror Files · tests/test-confused-revert.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Matt Mackall - - Load All Authors

File last commit:

r14903:a934b924 stable


                r18759:9baf4330

default

Download file

             test-confused-revert.t
        
                    82 lines
            
             | 1.2 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-confused-revert.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init

        $ echo foo > a

        $ hg add a

        $ hg commit -m "1"

        $ echo bar > b

        $ hg add b

        $ hg remove a

      Should show a removed and b added:

        $ hg status

        A b

        R a

        $ hg revert --all

        undeleting a

        forgetting b

      Should show b unknown and a back to normal:

        $ hg status

        ? b

        $ rm b

        $ hg co -C 0

        0 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ echo foo-a > a

        $ hg commit -m "2a"

        $ hg co -C 0

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ echo foo-b > a

        $ hg commit -m "2b"

        created new head

        $ HGMERGE=true hg merge 1

        merging a

        0 files updated, 1 files merged, 0 files removed, 0 files unresolved

        (branch merge, don't forget to commit)

      Should show foo-b:

        $ cat a

        foo-b

        $ echo bar > b

        $ hg add b

        $ rm a

        $ hg remove a

      Should show a removed and b added:

        $ hg status

        A b

        R a

      Revert should fail:

        $ hg revert

        abort: uncommitted merge with no revision specified

        (use "hg update" or see "hg help revert")

        [255]

      Revert should be ok now:

        $ hg revert -r2 --all

        undeleting a

        forgetting b

      Should show b unknown and a marked modified (merged):

        $ hg status

        M a

        ? b

      Should show foo-b:

        $ cat a

        foo-b

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init
				$ echo foo > a
				$ hg add a
				$ hg commit -m "1"

				$ echo bar > b
				$ hg add b
				$ hg remove a

				Should show a removed and b added:

				$ hg status
				A b
				R a

				$ hg revert --all
				undeleting a
				forgetting b

				Should show b unknown and a back to normal:

				$ hg status
				? b

				$ rm b

				$ hg co -C 0
				0 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ echo foo-a > a
				$ hg commit -m "2a"

				$ hg co -C 0
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ echo foo-b > a
				$ hg commit -m "2b"
				created new head

				$ HGMERGE=true hg merge 1
				merging a
				0 files updated, 1 files merged, 0 files removed, 0 files unresolved
				(branch merge, don't forget to commit)

				Should show foo-b:

				$ cat a
				foo-b

				$ echo bar > b
				$ hg add b
				$ rm a
				$ hg remove a

				Should show a removed and b added:

				$ hg status
				A b
				R a

				Revert should fail:

				$ hg revert
				abort: uncommitted merge with no revision specified
				(use "hg update" or see "hg help revert")
				[255]

				Revert should be ok now:

				$ hg revert -r2 --all
				undeleting a
				forgetting b

				Should show b unknown and a marked modified (merged):

				$ hg status
				M a
				? b

				Should show foo-b:

				$ cat a
				foo-b