upstream/mercurial-mirror Files · tests/test-convert-bzr-114.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Matt Mackall - - Load All Authors

File last commit:

r12513:d1f88ae4 default


                r18759:9baf4330

default

Download file

             test-convert-bzr-114.t
        
                    39 lines
            
             | 936 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-convert-bzr-114.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ "$TESTDIR/hghave" bzr114 || exit 80

        $ . "$TESTDIR/bzr-definitions"

      The file/directory replacement can only be reproduced on

      bzr >= 1.4. Merge it back in test-convert-bzr-directories once

      this version becomes mainstream.

      replace file with dir

        $ mkdir test-replace-file-with-dir

        $ cd test-replace-file-with-dir

        $ bzr init -q source

        $ cd source

        $ echo d > d

        $ bzr add -q d

        $ bzr commit -q -m 'add d file'

        $ rm d

        $ mkdir d

        $ bzr add -q d

        $ bzr commit -q -m 'replace with d dir'

        $ echo a > d/a

        $ bzr add -q d/a

        $ bzr commit -q -m 'add d/a'

        $ cd ..

        $ hg convert source source-hg

        initializing destination source-hg repository

        scanning source...

        sorting...

        converting...

        2 add d file

        1 replace with d dir

        0 add d/a

        $ manifest source-hg tip

        % manifest of tip

        644   d/a

        $ cd source-hg

        $ hg update

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ cd ../..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages


				$ "$TESTDIR/hghave" bzr114 \|\| exit 80
				$ . "$TESTDIR/bzr-definitions"

				The file/directory replacement can only be reproduced on
				bzr >= 1.4. Merge it back in test-convert-bzr-directories once
				this version becomes mainstream.
				replace file with dir

				$ mkdir test-replace-file-with-dir
				$ cd test-replace-file-with-dir
				$ bzr init -q source
				$ cd source
				$ echo d > d
				$ bzr add -q d
				$ bzr commit -q -m 'add d file'
				$ rm d
				$ mkdir d
				$ bzr add -q d
				$ bzr commit -q -m 'replace with d dir'
				$ echo a > d/a
				$ bzr add -q d/a
				$ bzr commit -q -m 'add d/a'
				$ cd ..
				$ hg convert source source-hg
				initializing destination source-hg repository
				scanning source...
				sorting...
				converting...
				2 add d file
				1 replace with d dir
				0 add d/a
				$ manifest source-hg tip
				% manifest of tip
				644 d/a
				$ cd source-hg
				$ hg update
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ cd ../..