upstream/mercurial-mirror Files · tests/test-debugindexdot.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

timeless@mozdev.org - - Load All Authors

File last commit:

r17490:a03c3ba3 default


                r18759:9baf4330

default

Download file

             test-debugindexdot.t
        
                    25 lines
            
             | 435 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-debugindexdot.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      Just exercise debugindexdot

      Create a short file history including a merge.

        $ hg init t

        $ cd t

        $ echo a > a

        $ hg ci -qAm t1 -d '0 0'

        $ echo a >> a

        $ hg ci -m t2 -d '1 0'

        $ hg up -qC 0

        $ echo b >> a

        $ hg ci -m t3 -d '2 0'

        created new head

        $ HGMERGE=true hg merge -q

        $ hg ci -m merge -d '3 0'

        $ hg debugindexdot .hg/store/data/a.i

        digraph G {

        	-1 -> 0

        	0 -> 1

        	0 -> 2

        	2 -> 3

        	1 -> 3

        }

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				Just exercise debugindexdot
				Create a short file history including a merge.
				$ hg init t
				$ cd t
				$ echo a > a
				$ hg ci -qAm t1 -d '0 0'
				$ echo a >> a
				$ hg ci -m t2 -d '1 0'
				$ hg up -qC 0
				$ echo b >> a
				$ hg ci -m t3 -d '2 0'
				created new head
				$ HGMERGE=true hg merge -q
				$ hg ci -m merge -d '3 0'

				$ hg debugindexdot .hg/store/data/a.i
				digraph G {
				-1 -> 0
				0 -> 1
				0 -> 2
				2 -> 3
				1 -> 3
				}

				$ cd ..