upstream/mercurial-mirror Files · tests/test-debugrename.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Adrian Buehlmann - - Load All Authors

File last commit:

r12285:5d9bc49b default


                r18759:9baf4330

default

Download file

             test-debugrename.t
        
                    18 lines
            
             | 371 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-debugrename.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init

        $ echo a > a

        $ hg ci -Am t

        adding a

        $ hg mv a b

        $ hg ci -Am t1

        $ hg debugrename b

        b renamed from a:b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3

        $ hg mv b a

        $ hg ci -Am t2

        $ hg debugrename a

        a renamed from b:37d9b5d994eab34eda9c16b195ace52c7b129980

        $ hg debugrename --rev 1 b

        b renamed from a:b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init
				$ echo a > a
				$ hg ci -Am t
				adding a

				$ hg mv a b
				$ hg ci -Am t1
				$ hg debugrename b
				b renamed from a:b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3

				$ hg mv b a
				$ hg ci -Am t2
				$ hg debugrename a
				a renamed from b:37d9b5d994eab34eda9c16b195ace52c7b129980

				$ hg debugrename --rev 1 b
				b renamed from a:b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3