upstream/mercurial-mirror Files · tests/test-diff-copy-depth.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Adrian Buehlmann - - Load All Authors

File last commit:

r12150:bca69641 default


                r18759:9baf4330

default

Download file

             test-diff-copy-depth.t
        
                    51 lines
            
             | 795 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-diff-copy-depth.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ for i in aaa zzz; do

        >     hg init t

        >     cd t

        > 

        >     echo

        >     echo "-- With $i"

        > 

        >     touch file

        >     hg add file

        >     hg ci -m "Add"

        > 

        >     hg cp file $i

        >     hg ci -m "a -> $i"

        > 

        >     hg cp $i other-file

        >     echo "different" >> $i

        >     hg ci -m "$i -> other-file"

        > 

        >     hg cp other-file somename

        > 

        >     echo "Status":

        >     hg st -C

        >     echo

        >     echo "Diff:"

        >     hg diff -g

        > 

        >     cd ..

        >     rm -rf t

        > done

        -- With aaa

        Status:

        A somename

          other-file

        Diff:

        diff --git a/other-file b/somename

        copy from other-file

        copy to somename

        -- With zzz

        Status:

        A somename

          other-file

        Diff:

        diff --git a/other-file b/somename

        copy from other-file

        copy to somename

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ for i in aaa zzz; do
				> hg init t
				> cd t
				>
				> echo
				> echo "-- With $i"
				>
				> touch file
				> hg add file
				> hg ci -m "Add"
				>
				> hg cp file $i
				> hg ci -m "a -> $i"
				>
				> hg cp $i other-file
				> echo "different" >> $i
				> hg ci -m "$i -> other-file"
				>
				> hg cp other-file somename
				>
				> echo "Status":
				> hg st -C
				> echo
				> echo "Diff:"
				> hg diff -g
				>
				> cd ..
				> rm -rf t
				> done

				-- With aaa
				Status:
				A somename
				other-file

				Diff:
				diff --git a/other-file b/somename
				copy from other-file
				copy to somename

				-- With zzz
				Status:
				A somename
				other-file

				Diff:
				diff --git a/other-file b/somename
				copy from other-file
				copy to somename