upstream/mercurial-mirror Files · tests/test-dispatch.py

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Idan Kamara - - Load All Authors

File last commit:

r14438:08bfec2e default


                r18759:9baf4330

default

Download file

             test-dispatch.py
        
                    33 lines
            
             | 786 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-dispatch.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      import os

      from mercurial import dispatch

      def testdispatch(cmd):

          """Simple wrapper around dispatch.dispatch()

          Prints command and result value, but does not handle quoting.

          """

          print "running: %s" % (cmd,)

          req = dispatch.request(cmd.split())

          result = dispatch.dispatch(req)

          print "result: %r" % (result,)

      testdispatch("init test1")

      os.chdir('test1')

      # create file 'foo', add and commit

      f = open('foo', 'wb')

      f.write('foo\n')

      f.close()

      testdispatch("add foo")

      testdispatch("commit -m commit1 -d 2000-01-01 foo")

      # append to file 'foo' and commit

      f = open('foo', 'ab')

      f.write('bar\n')

      f.close()

      testdispatch("commit -m commit2 -d 2000-01-02 foo")

      # check 88803a69b24 (fancyopts modified command table)

      testdispatch("log -r 0")

      testdispatch("log -r tip")

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				import os
				from mercurial import dispatch

				def testdispatch(cmd):
				"""Simple wrapper around dispatch.dispatch()

				Prints command and result value, but does not handle quoting.
				"""
				print "running: %s" % (cmd,)
				req = dispatch.request(cmd.split())
				result = dispatch.dispatch(req)
				print "result: %r" % (result,)


				testdispatch("init test1")
				os.chdir('test1')

				# create file 'foo', add and commit
				f = open('foo', 'wb')
				f.write('foo\n')
				f.close()
				testdispatch("add foo")
				testdispatch("commit -m commit1 -d 2000-01-01 foo")

				# append to file 'foo' and commit
				f = open('foo', 'ab')
				f.write('bar\n')
				f.close()
				testdispatch("commit -m commit2 -d 2000-01-02 foo")

				# check 88803a69b24 (fancyopts modified command table)
				testdispatch("log -r 0")
				testdispatch("log -r tip")