upstream/mercurial-mirror Files · tests/test-empty-dir.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Matt Mackall - - Load All Authors

File last commit:

r12346:3b165c12 default


                r18759:9baf4330

default

Download file

             test-empty-dir.t
        
                    23 lines
            
             | 397 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-empty-dir.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init

        $ echo 123 > a

        $ hg add a

        $ hg commit -m "first" a

        $ mkdir sub

        $ echo 321 > sub/b

        $ hg add sub/b

        $ hg commit -m "second" sub/b

        $ cat sub/b

        321

        $ hg co 0

        0 files updated, 0 files merged, 1 files removed, 0 files unresolved

        $ cat sub/b 2>/dev/null || echo "sub/b not present"

        sub/b not present

        $ test -d sub || echo "sub not present"

        sub not present

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init

				$ echo 123 > a
				$ hg add a
				$ hg commit -m "first" a

				$ mkdir sub
				$ echo 321 > sub/b
				$ hg add sub/b
				$ hg commit -m "second" sub/b

				$ cat sub/b
				321

				$ hg co 0
				0 files updated, 0 files merged, 1 files removed, 0 files unresolved

				$ cat sub/b 2>/dev/null \|\| echo "sub/b not present"
				sub/b not present

				$ test -d sub \|\| echo "sub not present"
				sub not present