upstream/mercurial-mirror Files · tests/test-histedit-outgoing.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Mads Kiilerich - - Load All Authors

File last commit:

r17284:f3a7f05f stable


                r18759:9baf4330

default

Download file

             test-histedit-outgoing.t
        
                    84 lines
            
             | 2.1 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-histedit-outgoing.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ cat >> $HGRCPATH <<EOF

        > [extensions]

        > graphlog=

        > histedit=

        > EOF

        $ initrepos ()

        > {

        >     hg init r

        >     cd r

        >     for x in a b c ; do

        >         echo $x > $x

        >         hg add $x

        >         hg ci -m $x

        >     done

        >     cd ..

        >     hg clone r r2 | grep -v updating

        >     cd r2

        >     for x in d e f ; do

        >         echo $x > $x

        >         hg add $x

        >         hg ci -m $x

        >     done

        >     cd ..

        >     hg init r3

        >     cd r3

        >     for x in g h i ; do

        >         echo $x > $x

        >         hg add $x

        >         hg ci -m $x

        >     done

        >     cd ..

        > }

        $ initrepos

        3 files updated, 0 files merged, 0 files removed, 0 files unresolved

      show the edit commands offered by outgoing

        $ cd r2

        $ HGEDITOR=cat hg histedit --outgoing ../r | grep -v comparing | grep -v searching

        pick 055a42cdd887 3 d

        pick e860deea161a 4 e

        pick 652413bf663e 5 f

        # Edit history between 055a42cdd887 and 652413bf663e

        #

        # Commands:

        #  p, pick = use commit

        #  e, edit = use commit, but stop for amending

        #  f, fold = use commit, but fold into previous commit (combines N and N-1)

        #  d, drop = remove commit from history

        #  m, mess = edit message without changing commit content

        #

        0 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ cd ..

      show the error from unrelated repos

        $ cd r3

        $ HGEDITOR=cat hg histedit --outgoing ../r | grep -v comparing | grep -v searching

        abort: repository is unrelated

        [1]

        $ cd ..

      show the error from unrelated repos

        $ cd r3

        $ HGEDITOR=cat hg histedit --force --outgoing ../r

        comparing with ../r

        searching for changes

        warning: repository is unrelated

        pick 2a4042b45417 0 g

        pick 68c46b4927ce 1 h

        pick 51281e65ba79 2 i

        # Edit history between 2a4042b45417 and 51281e65ba79

        #

        # Commands:

        #  p, pick = use commit

        #  e, edit = use commit, but stop for amending

        #  f, fold = use commit, but fold into previous commit (combines N and N-1)

        #  d, drop = remove commit from history

        #  m, mess = edit message without changing commit content

        #

        0 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ cat >> $HGRCPATH <<EOF
				> [extensions]
				> graphlog=
				> histedit=
				> EOF

				$ initrepos ()
				> {
				> hg init r
				> cd r
				> for x in a b c ; do
				> echo $x > $x
				> hg add $x
				> hg ci -m $x
				> done
				> cd ..
				> hg clone r r2 \| grep -v updating
				> cd r2
				> for x in d e f ; do
				> echo $x > $x
				> hg add $x
				> hg ci -m $x
				> done
				> cd ..
				> hg init r3
				> cd r3
				> for x in g h i ; do
				> echo $x > $x
				> hg add $x
				> hg ci -m $x
				> done
				> cd ..
				> }

				$ initrepos
				3 files updated, 0 files merged, 0 files removed, 0 files unresolved

				show the edit commands offered by outgoing
				$ cd r2
				$ HGEDITOR=cat hg histedit --outgoing ../r \| grep -v comparing \| grep -v searching
				pick 055a42cdd887 3 d
				pick e860deea161a 4 e
				pick 652413bf663e 5 f

				# Edit history between 055a42cdd887 and 652413bf663e
				#
				# Commands:
				# p, pick = use commit
				# e, edit = use commit, but stop for amending
				# f, fold = use commit, but fold into previous commit (combines N and N-1)
				# d, drop = remove commit from history
				# m, mess = edit message without changing commit content
				#
				0 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ cd ..

				show the error from unrelated repos
				$ cd r3
				$ HGEDITOR=cat hg histedit --outgoing ../r \| grep -v comparing \| grep -v searching
				abort: repository is unrelated
				[1]
				$ cd ..

				show the error from unrelated repos
				$ cd r3
				$ HGEDITOR=cat hg histedit --force --outgoing ../r
				comparing with ../r
				searching for changes
				warning: repository is unrelated
				pick 2a4042b45417 0 g
				pick 68c46b4927ce 1 h
				pick 51281e65ba79 2 i

				# Edit history between 2a4042b45417 and 51281e65ba79
				#
				# Commands:
				# p, pick = use commit
				# e, edit = use commit, but stop for amending
				# f, fold = use commit, but fold into previous commit (combines N and N-1)
				# d, drop = remove commit from history
				# m, mess = edit message without changing commit content
				#
				0 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ cd ..