upstream/mercurial-mirror Files · tests/test-inotify-debuginotify.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Augie Fackler - - Load All Authors

File last commit:

r18590:104e1204 default


                r18759:9baf4330

default

Download file

             test-inotify-debuginotify.t
        
                    41 lines
            
             | 565 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-inotify-debuginotify.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ "$TESTDIR/hghave" inotify || exit 80

        $ hg init

        $ echo "[extensions]" >> $HGRCPATH

        $ echo "inotify=" >> $HGRCPATH

      inserve

        $ hg inserve -d --pid-file=hg.pid

        $ cat hg.pid >> "$DAEMON_PIDS"

      let the daemon finish its stuff

        $ sleep 1

      empty

        $ hg debuginotify

        directories being watched:

          /

          .hg/

        $ mkdir a

        $ sleep 1

      only 'a

        $ hg debuginotify

        directories being watched:

          /

          .hg/

          a/

        $ rmdir a

        $ sleep 1

      empty again

        $ hg debuginotify

        directories being watched:

          /

          .hg/

        $ "$TESTDIR/killdaemons.py" hg.pid

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages


				$ "$TESTDIR/hghave" inotify \|\| exit 80
				$ hg init
				$ echo "[extensions]" >> $HGRCPATH
				$ echo "inotify=" >> $HGRCPATH

				inserve

				$ hg inserve -d --pid-file=hg.pid
				$ cat hg.pid >> "$DAEMON_PIDS"

				let the daemon finish its stuff

				$ sleep 1

				empty

				$ hg debuginotify
				directories being watched:
				/
				.hg/
				$ mkdir a
				$ sleep 1

				only 'a

				$ hg debuginotify
				directories being watched:
				/
				.hg/
				a/
				$ rmdir a
				$ sleep 1

				empty again

				$ hg debuginotify
				directories being watched:
				/
				.hg/
				$ "$TESTDIR/killdaemons.py" hg.pid