upstream/mercurial-mirror Files · tests/test-lock-badness.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Mads Kiilerich - - Load All Authors

File last commit:

r15443:a1914d21 default


                r18759:9baf4330

default

Download file

             test-lock-badness.t
        
                    24 lines
            
             | 440 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-lock-badness.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ "$TESTDIR/hghave" unix-permissions || exit 80

        $ hg init a

        $ echo a > a/a

        $ hg -R a ci -A -m a

        adding a

        $ hg clone a b

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ echo b > b/b

        $ hg -R b ci -A -m b

        adding b

        $ chmod 100 a/.hg/store

        $ hg -R b push a

        pushing to a

        abort: could not lock repository a: Permission denied

        [255]

        $ chmod 700 a/.hg/store

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ "$TESTDIR/hghave" unix-permissions \|\| exit 80

				$ hg init a
				$ echo a > a/a
				$ hg -R a ci -A -m a
				adding a

				$ hg clone a b
				updating to branch default
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved

				$ echo b > b/b
				$ hg -R b ci -A -m b
				adding b

				$ chmod 100 a/.hg/store

				$ hg -R b push a
				pushing to a
				abort: could not lock repository a: Permission denied
				[255]

				$ chmod 700 a/.hg/store