upstream/mercurial-mirror Files · tests/test-mactext.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Martin Geisler - - Load All Authors

File last commit:

r16932:7985a9e2 default


                r18759:9baf4330

default

Download file

             test-mactext.t
        
                    38 lines
            
             | 1019 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-mactext.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ cat > unix2mac.py <<EOF

        > import sys

        > 

        > for path in sys.argv[1:]:

        >     data = file(path, 'rb').read()

        >     data = data.replace('\n', '\r')

        >     file(path, 'wb').write(data)

        > EOF

        $ cat > print.py <<EOF

        > import sys

        > print(sys.stdin.read().replace('\n', '<LF>').replace('\r', '<CR>').replace('\0', '<NUL>'))

        > EOF

        $ hg init

        $ echo '[hooks]' >> .hg/hgrc

        $ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

        $ echo 'pretxnchangegroup.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

        $ cat .hg/hgrc

        [hooks]

        pretxncommit.cr = python:hgext.win32text.forbidcr

        pretxnchangegroup.cr = python:hgext.win32text.forbidcr

        $ echo hello > f

        $ hg add f

        $ hg ci -m 1

        $ python unix2mac.py f

        $ hg ci -m 2

        attempt to commit or push text file(s) using CR line endings

        in dea860dc51ec: f

        transaction abort!

        rollback completed

        abort: pretxncommit.cr hook failed

        [255]

        $ hg cat f | python print.py

        hello<LF>

        $ cat f | python print.py

        hello<CR>

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages


				$ cat > unix2mac.py <<EOF
				> import sys
				>
				> for path in sys.argv[1:]:
				> data = file(path, 'rb').read()
				> data = data.replace('\n', '\r')
				> file(path, 'wb').write(data)
				> EOF
				$ cat > print.py <<EOF
				> import sys
				> print(sys.stdin.read().replace('\n', '<LF>').replace('\r', '<CR>').replace('\0', '<NUL>'))
				> EOF
				$ hg init
				$ echo '[hooks]' >> .hg/hgrc
				$ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc
				$ echo 'pretxnchangegroup.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc
				$ cat .hg/hgrc
				[hooks]
				pretxncommit.cr = python:hgext.win32text.forbidcr
				pretxnchangegroup.cr = python:hgext.win32text.forbidcr

				$ echo hello > f
				$ hg add f
				$ hg ci -m 1

				$ python unix2mac.py f
				$ hg ci -m 2
				attempt to commit or push text file(s) using CR line endings
				in dea860dc51ec: f
				transaction abort!
				rollback completed
				abort: pretxncommit.cr hook failed
				[255]
				$ hg cat f \| python print.py
				hello<LF>
				$ cat f \| python print.py
				hello<CR>