upstream/mercurial-mirror Files · tests/test-template-engine.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Bryan O'Sullivan - - Load All Authors

File last commit:

r17358:2917f82f default


                r18759:9baf4330

default

Download file

             test-template-engine.t
        
                    47 lines
            
             | 1.3 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-template-engine.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ cat > engine.py << EOF

        > 

        > from mercurial import templater

        > 

        > class mytemplater(object):

        >     def __init__(self, loader, filters, defaults):

        >         self.loader = loader

        > 

        >     def process(self, t, map):

        >         tmpl = self.loader(t)

        >         for k, v in map.iteritems():

        >             if k in ('templ', 'ctx', 'repo', 'revcache', 'cache'):

        >                 continue

        >             if hasattr(v, '__call__'):

        >                 v = v(**map)

        >             v = templater.stringify(v)

        >             tmpl = tmpl.replace('{{%s}}' % k, v)

        >         yield tmpl

        > 

        > templater.engines['my'] = mytemplater

        > EOF

        $ hg init test

        $ echo '[extensions]' > test/.hg/hgrc

        $ echo "engine = `pwd`/engine.py" >> test/.hg/hgrc

        $ cd test

        $ cat > mymap << EOF

        > changeset = my:changeset.txt

        > EOF

        $ cat > changeset.txt << EOF

        > {{rev}} {{node}} {{author}}

        > EOF

        $ hg ci -Ama

        adding changeset.txt

        adding mymap

        $ hg log --style=./mymap

        0 97e5f848f0936960273bbf75be6388cd0350a32b test

        $ cat > changeset.txt << EOF

        > {{p1rev}} {{p1node}} {{p2rev}} {{p2node}}

        > EOF

        $ hg ci -Ama

        $ hg log --style=./mymap

        0 97e5f848f0936960273bbf75be6388cd0350a32b -1 0000000000000000000000000000000000000000

        -1 0000000000000000000000000000000000000000 -1 0000000000000000000000000000000000000000

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages


				$ cat > engine.py << EOF
				>
				> from mercurial import templater
				>
				> class mytemplater(object):
				> def __init__(self, loader, filters, defaults):
				> self.loader = loader
				>
				> def process(self, t, map):
				> tmpl = self.loader(t)
				> for k, v in map.iteritems():
				> if k in ('templ', 'ctx', 'repo', 'revcache', 'cache'):
				> continue
				> if hasattr(v, '__call__'):
				> v = v(**map)
				> v = templater.stringify(v)
				> tmpl = tmpl.replace('{{%s}}' % k, v)
				> yield tmpl
				>
				> templater.engines['my'] = mytemplater
				> EOF
				$ hg init test
				$ echo '[extensions]' > test/.hg/hgrc
				$ echo "engine = `pwd`/engine.py" >> test/.hg/hgrc
				$ cd test
				$ cat > mymap << EOF
				> changeset = my:changeset.txt
				> EOF
				$ cat > changeset.txt << EOF
				> {{rev}} {{node}} {{author}}
				> EOF
				$ hg ci -Ama
				adding changeset.txt
				adding mymap
				$ hg log --style=./mymap
				0 97e5f848f0936960273bbf75be6388cd0350a32b test

				$ cat > changeset.txt << EOF
				> {{p1rev}} {{p1node}} {{p2rev}} {{p2node}}
				> EOF
				$ hg ci -Ama
				$ hg log --style=./mymap
				0 97e5f848f0936960273bbf75be6388cd0350a32b -1 0000000000000000000000000000000000000000
				-1 0000000000000000000000000000000000000000 -1 0000000000000000000000000000000000000000

				$ cd ..