upstream/mercurial-mirror Files · tests/test-ui-color.py

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Matt Mackall - - Load All Authors

File last commit:

r17956:a08775ec default


                r18759:9baf4330

default

Download file

             test-ui-color.py
        
                    33 lines
            
             | 895 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-ui-color.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      import os, sys

      from hgext import color

      from mercurial import dispatch, ui

      # ensure errors aren't buffered

      testui = color.colorui()

      testui.pushbuffer()

      testui.write(('buffered\n'))

      testui.warn(('warning\n'))

      testui.write_err('error\n')

      print repr(testui.popbuffer())

      # test dispatch.dispatch with the same ui object

      hgrc = open(os.environ["HGRCPATH"], 'w')

      hgrc.write('[extensions]\n')

      hgrc.write('color=\n')

      hgrc.close()

      ui_ = ui.ui()

      ui_.setconfig('ui', 'formatted', 'True')

      # we're not interested in the output, so write that to devnull

      ui_.fout = open(os.devnull, 'w')

      # call some arbitrary command just so we go through

      # color's wrapped _runcommand twice.

      def runcmd():

          dispatch.dispatch(dispatch.request(['version', '-q'], ui_))

      runcmd()

      print "colored? " + str(issubclass(ui_.__class__, color.colorui))

      runcmd()

      print "colored? " + str(issubclass(ui_.__class__, color.colorui))

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				import os, sys
				from hgext import color
				from mercurial import dispatch, ui

				# ensure errors aren't buffered
				testui = color.colorui()
				testui.pushbuffer()
				testui.write(('buffered\n'))
				testui.warn(('warning\n'))
				testui.write_err('error\n')
				print repr(testui.popbuffer())

				# test dispatch.dispatch with the same ui object
				hgrc = open(os.environ["HGRCPATH"], 'w')
				hgrc.write('[extensions]\n')
				hgrc.write('color=\n')
				hgrc.close()

				ui_ = ui.ui()
				ui_.setconfig('ui', 'formatted', 'True')

				# we're not interested in the output, so write that to devnull
				ui_.fout = open(os.devnull, 'w')

				# call some arbitrary command just so we go through
				# color's wrapped _runcommand twice.
				def runcmd():
				dispatch.dispatch(dispatch.request(['version', '-q'], ui_))

				runcmd()
				print "colored? " + str(issubclass(ui_.__class__, color.colorui))
				runcmd()
				print "colored? " + str(issubclass(ui_.__class__, color.colorui))