upstream/mercurial-mirror Files · tests/test-username-newline.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Matt Mackall - - Load All Authors

File last commit:

r12346:3b165c12 default


                r18759:9baf4330

default

Download file

             test-username-newline.t
        
                    25 lines
            
             | 503 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-username-newline.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init

        $ touch a

        $ unset HGUSER

        $ echo "[ui]" >> .hg/hgrc

        $ echo "username= foo" >> .hg/hgrc

        $ echo "          bar1" >> .hg/hgrc

        $ hg ci -Am m

        adding a

        abort: username 'foo\nbar1' contains a newline

        [255]

        $ rm .hg/hgrc

        $ HGUSER=`(echo foo; echo bar2)` hg ci -Am m

        abort: username 'foo\nbar2' contains a newline

        [255]

        $ hg ci -Am m -u "`(echo foo; echo bar3)`"

        transaction abort!

        rollback completed

        abort: username 'foo\nbar3' contains a newline!

        [255]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init
				$ touch a

				$ unset HGUSER
				$ echo "[ui]" >> .hg/hgrc
				$ echo "username= foo" >> .hg/hgrc
				$ echo " bar1" >> .hg/hgrc

				$ hg ci -Am m
				adding a
				abort: username 'foo\nbar1' contains a newline

				[255]
				$ rm .hg/hgrc

				$ HGUSER=`(echo foo; echo bar2)` hg ci -Am m
				abort: username 'foo\nbar2' contains a newline

				[255]
				$ hg ci -Am m -u "`(echo foo; echo bar3)`"
				transaction abort!
				rollback completed
				abort: username 'foo\nbar3' contains a newline!
				[255]