upstream/mercurial-mirror Files · tests/filterpyflakes.py

localrepo: handle ValueError during repository opening...

localrepo: handle ValueError during repository opening Python 3.8 can raise ValueError on attempt of an I/O operation against an illegal path. This was causing test-remotefilelog-gc.t to fail on Python 3.8. This commit teaches repository opening to handle ValueError and re-raise an Abort on failure. An arguably better solution would be to implement this logic in the vfs layer. But that seems like a bag of worms and I don't want to go down that rabbit hole. Until users report uncaught ValueError exceptions in the wild, I think it is fine to patch this at the only occurrence our test harness is finding it. Differential Revision: https://phab.mercurial-scm.org/D7944

Augie Fackler - - Load All Authors

File last commit:

r43346:2372284d default


                r45469:9e5b4dbe

default

Download file

             filterpyflakes.py
        
                    37 lines
            
             | 891 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / filterpyflakes.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/usr/bin/env python

      # Filter output by pyflakes to control which warnings we check

      from __future__ import absolute_import, print_function

      import re

      import sys

      lines = []

      for line in sys.stdin:

          # We blacklist tests that are too noisy for us

          pats = [

              r"undefined name 'WindowsError'",

              r"redefinition of unused '[^']+' from line",

              # for cffi, allow re-exports from pure.*

              r"cffi/[^:]*:.*\bimport \*' used",

              r"cffi/[^:]*:.*\*' imported but unused",

          ]

          keep = True

          for pat in pats:

              if re.search(pat, line):

                  keep = False

                  break  # pattern matches

          if keep:

              fn = line.split(':', 1)[0]

              f = open(fn)

              data = f.read()

              f.close()

              if 'no-' 'check-code' in data:

                  continue

              lines.append(line)

      for line in lines:

          sys.stdout.write(line)

      print()

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/usr/bin/env python

				# Filter output by pyflakes to control which warnings we check

				from __future__ import absolute_import, print_function

				import re
				import sys

				lines = []
				for line in sys.stdin:
				# We blacklist tests that are too noisy for us
				pats = [
				r"undefined name 'WindowsError'",
				r"redefinition of unused '[^']+' from line",
				# for cffi, allow re-exports from pure.*
				r"cffi/[^:]:.\bimport \*' used",
				r"cffi/[^:]:.\*' imported but unused",
				]

				keep = True
				for pat in pats:
				if re.search(pat, line):
				keep = False
				break # pattern matches
				if keep:
				fn = line.split(':', 1)[0]
				f = open(fn)
				data = f.read()
				f.close()
				if 'no-' 'check-code' in data:
				continue
				lines.append(line)

				for line in lines:
				sys.stdout.write(line)
				print()