upstream/mercurial-mirror Files · tests/test-check-pyflakes.t

localrepo: handle ValueError during repository opening...

localrepo: handle ValueError during repository opening Python 3.8 can raise ValueError on attempt of an I/O operation against an illegal path. This was causing test-remotefilelog-gc.t to fail on Python 3.8. This commit teaches repository opening to handle ValueError and re-raise an Abort on failure. An arguably better solution would be to implement this logic in the vfs layer. But that seems like a bag of worms and I don't want to go down that rabbit hole. Until users report uncaught ValueError exceptions in the wild, I think it is fine to patch this at the only occurrence our test harness is finding it. Differential Revision: https://phab.mercurial-scm.org/D7944

av6 - - Load All Authors

File last commit:

r45464:3d409f4f default


                r45469:9e5b4dbe

default

Download file

             test-check-pyflakes.t
        
                    28 lines
            
             | 1006 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-check-pyflakes.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require test-repo pyflakes hg10

        $ . "$TESTDIR/helpers-testrepo.sh"

      run pyflakes on all tracked files ending in .py or without a file ending

      (skipping binary file random-seed)

        $ cat > test.py <<EOF

        > print(undefinedname)

        > EOF

        $ $PYTHON -m pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"

        test.py:1:* undefined name 'undefinedname' (glob)

        $ cd "`dirname "$TESTDIR"`"

        $ testrepohg locate 'set:**.py or grep("^#!.*python")' \

        > -X hgext/fsmonitor/pywatchman \

        > -X mercurial/pycompat.py -X contrib/python-zstandard \

        > -X mercurial/thirdparty/cbor \

        > -X mercurial/thirdparty/concurrent \

        > -X mercurial/thirdparty/zope \

        > 2>/dev/null \

        > | xargs $PYTHON -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"

        contrib/perf.py:*:* undefined name 'xrange' (glob) (?)

        mercurial/hgweb/server.py:*:* undefined name 'reload' (glob) (?)

        mercurial/util.py:*:* undefined name 'file' (glob) (?)

        mercurial/encoding.py:*:* undefined name 'localstr' (glob) (?)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require test-repo pyflakes hg10

				$ . "$TESTDIR/helpers-testrepo.sh"

				run pyflakes on all tracked files ending in .py or without a file ending
				(skipping binary file random-seed)

				$ cat > test.py <<EOF
				> print(undefinedname)
				> EOF
				$ $PYTHON -m pyflakes test.py 2>/dev/null \| "$TESTDIR/filterpyflakes.py"
				test.py:1:* undefined name 'undefinedname' (glob)

				$ cd "`dirname "$TESTDIR"`"

				$ testrepohg locate 'set:*.py or grep("^#!.python")' \
				> -X hgext/fsmonitor/pywatchman \
				> -X mercurial/pycompat.py -X contrib/python-zstandard \
				> -X mercurial/thirdparty/cbor \
				> -X mercurial/thirdparty/concurrent \
				> -X mercurial/thirdparty/zope \
				> 2>/dev/null \
				> \| xargs $PYTHON -m pyflakes 2>/dev/null \| "$TESTDIR/filterpyflakes.py"
				contrib/perf.py:: undefined name 'xrange' (glob) (?)
				mercurial/hgweb/server.py:: undefined name 'reload' (glob) (?)
				mercurial/util.py:: undefined name 'file' (glob) (?)
				mercurial/encoding.py:: undefined name 'localstr' (glob) (?)