upstream/mercurial-mirror Files · tests/test-clone-pull-corruption.t

localrepo: handle ValueError during repository opening...

localrepo: handle ValueError during repository opening Python 3.8 can raise ValueError on attempt of an I/O operation against an illegal path. This was causing test-remotefilelog-gc.t to fail on Python 3.8. This commit teaches repository opening to handle ValueError and re-raise an Abort on failure. An arguably better solution would be to implement this logic in the vfs layer. But that seems like a bag of worms and I don't want to go down that rabbit hole. Until users report uncaught ValueError exceptions in the wild, I think it is fine to patch this at the only occurrence our test harness is finding it. Differential Revision: https://phab.mercurial-scm.org/D7944

Meirambek Omyrzak - - Load All Authors

File last commit:

r39525:f1186c29 default


                r45469:9e5b4dbe

default

Download file

             test-clone-pull-corruption.t
        
                    53 lines
            
             | 1.2 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-clone-pull-corruption.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      Corrupt an hg repo with a pull started during an aborted commit

      Create two repos, so that one of them can pull from the other one.

        $ hg init source

        $ cd source

        $ touch foo

        $ hg add foo

        $ hg ci -m 'add foo'

        $ hg clone . ../corrupted

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ echo >> foo

        $ hg ci -m 'change foo'

      Add a hook to wait 5 seconds and then abort the commit

        $ cd ../corrupted

        $ echo "[hooks]" >> .hg/hgrc

        $ echo 'pretxncommit = sh -c "sleep 5; exit 1"' >> .hg/hgrc

      start a commit...

        $ touch bar

        $ hg add bar

        $ hg ci -m 'add bar' &

      ... and start a pull while the commit is still running

        $ sleep 1

        $ hg pull ../source 2>/dev/null

        pulling from ../source

        transaction abort!

        rollback completed

        abort: pretxncommit hook exited with status 1

        searching for changes

        adding changesets

        adding manifests

        adding file changes

        added 1 changesets with 1 changes to 1 files

        new changesets 52998019f625

        (run 'hg update' to get a working copy)

      see what happened

        $ wait

        $ hg verify

        checking changesets

        checking manifests

        crosschecking files in changesets and manifests

        checking files

        checked 2 changesets with 2 changes to 1 files

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				Corrupt an hg repo with a pull started during an aborted commit
				Create two repos, so that one of them can pull from the other one.

				$ hg init source
				$ cd source
				$ touch foo
				$ hg add foo
				$ hg ci -m 'add foo'
				$ hg clone . ../corrupted
				updating to branch default
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ echo >> foo
				$ hg ci -m 'change foo'

				Add a hook to wait 5 seconds and then abort the commit

				$ cd ../corrupted
				$ echo "[hooks]" >> .hg/hgrc
				$ echo 'pretxncommit = sh -c "sleep 5; exit 1"' >> .hg/hgrc

				start a commit...

				$ touch bar
				$ hg add bar
				$ hg ci -m 'add bar' &

				... and start a pull while the commit is still running

				$ sleep 1
				$ hg pull ../source 2>/dev/null
				pulling from ../source
				transaction abort!
				rollback completed
				abort: pretxncommit hook exited with status 1
				searching for changes
				adding changesets
				adding manifests
				adding file changes
				added 1 changesets with 1 changes to 1 files
				new changesets 52998019f625
				(run 'hg update' to get a working copy)

				see what happened

				$ wait
				$ hg verify
				checking changesets
				checking manifests
				crosschecking files in changesets and manifests
				checking files
				checked 2 changesets with 2 changes to 1 files

				$ cd ..