upstream/mercurial-mirror Files · tests/test-editor-filename.t

localrepo: handle ValueError during repository opening...

localrepo: handle ValueError during repository opening Python 3.8 can raise ValueError on attempt of an I/O operation against an illegal path. This was causing test-remotefilelog-gc.t to fail on Python 3.8. This commit teaches repository opening to handle ValueError and re-raise an Abort on failure. An arguably better solution would be to implement this logic in the vfs layer. But that seems like a bag of worms and I don't want to go down that rabbit hole. Until users report uncaught ValueError exceptions in the wild, I think it is fine to patch this at the only occurrence our test harness is finding it. Differential Revision: https://phab.mercurial-scm.org/D7944

Kyle Lippincott - - Load All Authors

File last commit:

r42766:f802a75d default


                r45469:9e5b4dbe

default

Download file

             test-editor-filename.t
        
                    64 lines
            
             | 1.4 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-editor-filename.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      Test temp file used with an editor has the expected suffix.

        $ hg init

      Create an editor that writes its arguments to stdout and set it to $HGEDITOR.

        $ cat > editor.sh << EOF

        > echo "\$@"

        > exit 1

        > EOF

        $ hg add editor.sh

        $ HGEDITOR="sh $TESTTMP/editor.sh"

        $ export HGEDITOR

      Verify that the path for a commit editor has the expected suffix.

        $ hg commit

        *.commit.hg.txt (glob)

        abort: edit failed: sh exited with status 1

        [255]

      Verify that the path for a histedit editor has the expected suffix.

        $ cat >> $HGRCPATH <<EOF

        > [extensions]

        > rebase=

        > histedit=

        > EOF

        $ hg commit --message 'At least one commit for histedit.'

        $ hg histedit

        *.histedit.hg.txt (glob)

        abort: edit failed: sh exited with status 1

        [255]

      Verify that when performing an action that has the side-effect of creating an

      editor for a diff, the file ends in .diff.

        $ echo 1 > one

        $ echo 2 > two

        $ hg add

        adding one

        adding two

        $ hg commit --interactive --config ui.interactive=true --config ui.interface=text << EOF

        > y

        > e

        > q

        > EOF

        diff --git a/one b/one

        new file mode 100644

        examine changes to 'one'?

        (enter ? for help) [Ynesfdaq?] y

        @@ -0,0 +1,1 @@

        +1

        record change 1/2 to 'one'?

        (enter ? for help) [Ynesfdaq?] e

        *.diff (glob)

        editor exited with exit code 1

        record change 1/2 to 'one'?

        (enter ? for help) [Ynesfdaq?] q

        abort: user quit

        [255]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				Test temp file used with an editor has the expected suffix.

				$ hg init

				Create an editor that writes its arguments to stdout and set it to $HGEDITOR.

				$ cat > editor.sh << EOF
				> echo "\$@"
				> exit 1
				> EOF
				$ hg add editor.sh
				$ HGEDITOR="sh $TESTTMP/editor.sh"
				$ export HGEDITOR

				Verify that the path for a commit editor has the expected suffix.

				$ hg commit
				*.commit.hg.txt (glob)
				abort: edit failed: sh exited with status 1
				[255]

				Verify that the path for a histedit editor has the expected suffix.

				$ cat >> $HGRCPATH <<EOF
				> [extensions]
				> rebase=
				> histedit=
				> EOF
				$ hg commit --message 'At least one commit for histedit.'
				$ hg histedit
				*.histedit.hg.txt (glob)
				abort: edit failed: sh exited with status 1
				[255]

				Verify that when performing an action that has the side-effect of creating an
				editor for a diff, the file ends in .diff.

				$ echo 1 > one
				$ echo 2 > two
				$ hg add
				adding one
				adding two
				$ hg commit --interactive --config ui.interactive=true --config ui.interface=text << EOF
				> y
				> e
				> q
				> EOF
				diff --git a/one b/one
				new file mode 100644
				examine changes to 'one'?
				(enter ? for help) [Ynesfdaq?] y

				@@ -0,0 +1,1 @@
				+1
				record change 1/2 to 'one'?
				(enter ? for help) [Ynesfdaq?] e

				*.diff (glob)
				editor exited with exit code 1
				record change 1/2 to 'one'?
				(enter ? for help) [Ynesfdaq?] q

				abort: user quit
				[255]