upstream/mercurial-mirror Files · tests/test-hghave.t

localrepo: handle ValueError during repository opening...

localrepo: handle ValueError during repository opening Python 3.8 can raise ValueError on attempt of an I/O operation against an illegal path. This was causing test-remotefilelog-gc.t to fail on Python 3.8. This commit teaches repository opening to handle ValueError and re-raise an Abort on failure. An arguably better solution would be to implement this logic in the vfs layer. But that seems like a bag of worms and I don't want to go down that rabbit hole. Until users report uncaught ValueError exceptions in the wild, I think it is fine to patch this at the only occurrence our test harness is finding it. Differential Revision: https://phab.mercurial-scm.org/D7944

Gregory Szorc - - Load All Authors

File last commit:

r43275:7eac24de default


                r45469:9e5b4dbe

default

Download file

             test-hghave.t
        
                    46 lines
            
             | 1.1 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-hghave.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ . "$TESTDIR/helpers-testrepo.sh"

      Testing that hghave does not crash when checking features

        $ hghave --test-features 2>/dev/null

      Testing hghave extensibility for third party tools

        $ cat > hghaveaddon.py <<EOF

        > import hghave

        > @hghave.check("custom", "custom hghave feature")

        > def has_custom():

        >     return True

        > EOF

      (invocation via run-tests.py)

        $ cat > test-hghaveaddon.t <<EOF

        > #require custom

        >   $ echo foo

        >   foo

        > EOF

        $ ( \

        > testrepohgenv; \

        > "$PYTHON" $TESTDIR/run-tests.py --with-hg=`which hg` -j 1 \

        >    $HGTEST_RUN_TESTS_PURE test-hghaveaddon.t \

        > )

        running 1 tests using 1 parallel processes 

        .

        # Ran 1 tests, 0 skipped, 0 failed.

      (invocation via command line)

        $ unset TESTDIR

        $ hghave custom

      (terminate with exit code 2 at failure of importing hghaveaddon.py)

        $ rm hghaveaddon.*

        $ cat > hghaveaddon.py <<NO_CHECK_EOF

        > importing this file should cause syntax error

        > NO_CHECK_EOF

        $ hghave custom

        failed to import hghaveaddon.py from '.': invalid syntax (hghaveaddon.py, line 1)

        [2]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ . "$TESTDIR/helpers-testrepo.sh"

				Testing that hghave does not crash when checking features

				$ hghave --test-features 2>/dev/null

				Testing hghave extensibility for third party tools

				$ cat > hghaveaddon.py <<EOF
				> import hghave
				> @hghave.check("custom", "custom hghave feature")
				> def has_custom():
				> return True
				> EOF

				(invocation via run-tests.py)

				$ cat > test-hghaveaddon.t <<EOF
				> #require custom
				> $ echo foo
				> foo
				> EOF
				$ ( \
				> testrepohgenv; \
				> "$PYTHON" $TESTDIR/run-tests.py --with-hg=`which hg` -j 1 \
				> $HGTEST_RUN_TESTS_PURE test-hghaveaddon.t \
				> )
				running 1 tests using 1 parallel processes
				.
				# Ran 1 tests, 0 skipped, 0 failed.

				(invocation via command line)

				$ unset TESTDIR
				$ hghave custom

				(terminate with exit code 2 at failure of importing hghaveaddon.py)

				$ rm hghaveaddon.*
				$ cat > hghaveaddon.py <<NO_CHECK_EOF
				> importing this file should cause syntax error
				> NO_CHECK_EOF

				$ hghave custom
				failed to import hghaveaddon.py from '.': invalid syntax (hghaveaddon.py, line 1)
				[2]