upstream/mercurial-mirror Files · tests/test-hooklib-reject_new_heads.t

localrepo: handle ValueError during repository opening...

localrepo: handle ValueError during repository opening Python 3.8 can raise ValueError on attempt of an I/O operation against an illegal path. This was causing test-remotefilelog-gc.t to fail on Python 3.8. This commit teaches repository opening to handle ValueError and re-raise an Abort on failure. An arguably better solution would be to implement this logic in the vfs layer. But that seems like a bag of worms and I don't want to go down that rabbit hole. Until users report uncaught ValueError exceptions in the wild, I think it is fine to patch this at the only occurrence our test harness is finding it. Differential Revision: https://phab.mercurial-scm.org/D7944

Joerg Sonnenberger - - Load All Authors

File last commit:

r44897:4cabeea6 default


                r45469:9e5b4dbe

default

Download file

             test-hooklib-reject_new_heads.t
        
                    53 lines
            
             | 1.4 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-hooklib-reject_new_heads.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ cat <<EOF >> $HGRCPATH

        > [extensions]

        > hooklib =

        > 

        > [phases]

        > publish = False

        > EOF

        $ hg init a

        $ hg --cwd a debugbuilddag '.:parent.*parent'

        $ hg --cwd a log -G

        o  changeset:   2:fa942426a6fd

        |  tag:         tip

        |  parent:      0:1ea73414a91b

        |  user:        debugbuilddag

        |  date:        Thu Jan 01 00:00:02 1970 +0000

        |  summary:     r2

        |

        | o  changeset:   1:66f7d451a68b

        |/   user:        debugbuilddag

        |    date:        Thu Jan 01 00:00:01 1970 +0000

        |    summary:     r1

        |

        o  changeset:   0:1ea73414a91b

           tag:         parent

           user:        debugbuilddag

           date:        Thu Jan 01 00:00:00 1970 +0000

           summary:     r0

        $ hg init b

        $ cat <<EOF >> b/.hg/hgrc

        > [hooks]

        > pretxnclose.reject_new_heads = \

        >   python:hgext.hooklib.reject_new_heads.hook

        > EOF

        $ hg --cwd b pull ../a

        pulling from ../a

        requesting all changes

        adding changesets

        adding manifests

        adding file changes

        error: pretxnclose.reject_new_heads hook failed: Changes on branch 'default' resulted in multiple heads

        transaction abort!

        rollback completed

        abort: Changes on branch 'default' resulted in multiple heads

        [255]

        $ hg --cwd b pull ../a -r 1ea73414a91b

        pulling from ../a

        adding changesets

        adding manifests

        adding file changes

        added 1 changesets with 0 changes to 0 files

        new changesets 1ea73414a91b (1 drafts)

        (run 'hg update' to get a working copy)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ cat <<EOF >> $HGRCPATH
				> [extensions]
				> hooklib =
				>
				> [phases]
				> publish = False
				> EOF
				$ hg init a
				$ hg --cwd a debugbuilddag '.:parent.*parent'
				$ hg --cwd a log -G
				o changeset: 2:fa942426a6fd
				\| tag: tip
				\| parent: 0:1ea73414a91b
				\| user: debugbuilddag
				\| date: Thu Jan 01 00:00:02 1970 +0000
				\| summary: r2
				\|
				\| o changeset: 1:66f7d451a68b
				\|/ user: debugbuilddag
				\| date: Thu Jan 01 00:00:01 1970 +0000
				\| summary: r1
				\|
				o changeset: 0:1ea73414a91b
				tag: parent
				user: debugbuilddag
				date: Thu Jan 01 00:00:00 1970 +0000
				summary: r0

				$ hg init b
				$ cat <<EOF >> b/.hg/hgrc
				> [hooks]
				> pretxnclose.reject_new_heads = \
				> python:hgext.hooklib.reject_new_heads.hook
				> EOF
				$ hg --cwd b pull ../a
				pulling from ../a
				requesting all changes
				adding changesets
				adding manifests
				adding file changes
				error: pretxnclose.reject_new_heads hook failed: Changes on branch 'default' resulted in multiple heads
				transaction abort!
				rollback completed
				abort: Changes on branch 'default' resulted in multiple heads
				[255]
				$ hg --cwd b pull ../a -r 1ea73414a91b
				pulling from ../a
				adding changesets
				adding manifests
				adding file changes
				added 1 changesets with 0 changes to 0 files
				new changesets 1ea73414a91b (1 drafts)
				(run 'hg update' to get a working copy)