upstream/mercurial-mirror Files · tests/test-journal-exists.t

localrepo: handle ValueError during repository opening...

localrepo: handle ValueError during repository opening Python 3.8 can raise ValueError on attempt of an I/O operation against an illegal path. This was causing test-remotefilelog-gc.t to fail on Python 3.8. This commit teaches repository opening to handle ValueError and re-raise an Abort on failure. An arguably better solution would be to implement this logic in the vfs layer. But that seems like a bag of worms and I don't want to go down that rabbit hole. Until users report uncaught ValueError exceptions in the wild, I think it is fine to patch this at the only occurrence our test harness is finding it. Differential Revision: https://phab.mercurial-scm.org/D7944

Valentin Gatien-Baron - - Load All Authors

File last commit:

r44830:7a4e1d24 default


                r45469:9e5b4dbe

default

Download file

             test-journal-exists.t
        
                    60 lines
            
             | 1.4 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-journal-exists.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init

        $ echo a > a

        $ hg ci -Am0

        adding a

        $ hg -q clone . foo

        $ touch .hg/store/journal

        $ echo foo > a

        $ hg ci -Am0

        abort: abandoned transaction found!

        (run 'hg recover' to clean up transaction)

        [255]

        $ hg recover

        rolling back interrupted transaction

        (verify step skipped, run `hg verify` to check your repository content)

      recover, explicit verify

        $ touch .hg/store/journal

        $ hg ci -Am0

        abort: abandoned transaction found!

        (run 'hg recover' to clean up transaction)

        [255]

        $ hg recover --verify

        rolling back interrupted transaction

        checking changesets

        checking manifests

        crosschecking files in changesets and manifests

        checking files

        checked 1 changesets with 1 changes to 1 files

      recover, no verify

        $ touch .hg/store/journal

        $ hg ci -Am0

        abort: abandoned transaction found!

        (run 'hg recover' to clean up transaction)

        [255]

        $ hg recover --no-verify

        rolling back interrupted transaction

        (verify step skipped, run `hg verify` to check your repository content)

      Check that zero-size journals are correctly aborted:

      #if unix-permissions no-root

        $ hg bundle -qa repo.hg

        $ chmod -w foo/.hg/store/00changelog.i

        $ hg -R foo unbundle repo.hg

        adding changesets

        abort: Permission denied: '$TESTTMP/foo/.hg/store/.00changelog.i-*' (glob)

        [255]

        $ if test -f foo/.hg/store/journal; then echo 'journal exists :-('; fi

      #endif

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init
				$ echo a > a
				$ hg ci -Am0
				adding a

				$ hg -q clone . foo

				$ touch .hg/store/journal

				$ echo foo > a
				$ hg ci -Am0
				abort: abandoned transaction found!
				(run 'hg recover' to clean up transaction)
				[255]

				$ hg recover
				rolling back interrupted transaction
				(verify step skipped, run `hg verify` to check your repository content)

				recover, explicit verify

				$ touch .hg/store/journal
				$ hg ci -Am0
				abort: abandoned transaction found!
				(run 'hg recover' to clean up transaction)
				[255]
				$ hg recover --verify
				rolling back interrupted transaction
				checking changesets
				checking manifests
				crosschecking files in changesets and manifests
				checking files
				checked 1 changesets with 1 changes to 1 files

				recover, no verify

				$ touch .hg/store/journal
				$ hg ci -Am0
				abort: abandoned transaction found!
				(run 'hg recover' to clean up transaction)
				[255]
				$ hg recover --no-verify
				rolling back interrupted transaction
				(verify step skipped, run `hg verify` to check your repository content)


				Check that zero-size journals are correctly aborted:

				#if unix-permissions no-root
				$ hg bundle -qa repo.hg
				$ chmod -w foo/.hg/store/00changelog.i

				$ hg -R foo unbundle repo.hg
				adding changesets
				abort: Permission denied: '$TESTTMP/foo/.hg/store/.00changelog.i-*' (glob)
				[255]

				$ if test -f foo/.hg/store/journal; then echo 'journal exists :-('; fi
				#endif