upstream/mercurial-mirror Files · tests/test-mactext.t

localrepo: handle ValueError during repository opening...

localrepo: handle ValueError during repository opening Python 3.8 can raise ValueError on attempt of an I/O operation against an illegal path. This was causing test-remotefilelog-gc.t to fail on Python 3.8. This commit teaches repository opening to handle ValueError and re-raise an Abort on failure. An arguably better solution would be to implement this logic in the vfs layer. But that seems like a bag of worms and I don't want to go down that rabbit hole. Until users report uncaught ValueError exceptions in the wild, I think it is fine to patch this at the only occurrence our test harness is finding it. Differential Revision: https://phab.mercurial-scm.org/D7944

Gregory Szorc - - Load All Authors

File last commit:

r45132:da9b7f96 default


                r45469:9e5b4dbe

default

Download file

             test-mactext.t
        
                    36 lines
            
             | 981 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-mactext.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ cat > unix2mac.py <<EOF

        > import sys

        > 

        > for path in sys.argv[1:]:

        >     data = open(path, 'rb').read()

        >     data = data.replace(b'\n', b'\r')

        >     open(path, 'wb').write(data)

        > EOF

        $ hg init

        $ echo '[hooks]' >> .hg/hgrc

        $ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

        $ echo 'pretxnchangegroup.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

        $ cat .hg/hgrc

        [hooks]

        pretxncommit.cr = python:hgext.win32text.forbidcr

        pretxnchangegroup.cr = python:hgext.win32text.forbidcr

        $ echo hello > f

        $ hg add f

        $ hg ci -m 1

        $ "$PYTHON" unix2mac.py f

        $ hg ci -m 2

        attempt to commit or push text file(s) using CR line endings

        in dea860dc51ec: f

        transaction abort!

        rollback completed

        abort: pretxncommit.cr hook failed

        [255]

        $ hg cat f | f --hexdump

        0000: 68 65 6c 6c 6f 0a                               |hello.|

        $ f --hexdump f

        f:

        0000: 68 65 6c 6c 6f 0d                               |hello.|

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages


				$ cat > unix2mac.py <<EOF
				> import sys
				>
				> for path in sys.argv[1:]:
				> data = open(path, 'rb').read()
				> data = data.replace(b'\n', b'\r')
				> open(path, 'wb').write(data)
				> EOF
				$ hg init
				$ echo '[hooks]' >> .hg/hgrc
				$ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc
				$ echo 'pretxnchangegroup.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc
				$ cat .hg/hgrc
				[hooks]
				pretxncommit.cr = python:hgext.win32text.forbidcr
				pretxnchangegroup.cr = python:hgext.win32text.forbidcr

				$ echo hello > f
				$ hg add f
				$ hg ci -m 1

				$ "$PYTHON" unix2mac.py f
				$ hg ci -m 2
				attempt to commit or push text file(s) using CR line endings
				in dea860dc51ec: f
				transaction abort!
				rollback completed
				abort: pretxncommit.cr hook failed
				[255]
				$ hg cat f \| f --hexdump

				0000: 68 65 6c 6c 6f 0a \|hello.\|
				$ f --hexdump f
				f:
				0000: 68 65 6c 6c 6f 0d \|hello.\|