upstream/mercurial-mirror Files · tests/test-pushvars.t

localrepo: handle ValueError during repository opening...

localrepo: handle ValueError during repository opening Python 3.8 can raise ValueError on attempt of an I/O operation against an illegal path. This was causing test-remotefilelog-gc.t to fail on Python 3.8. This commit teaches repository opening to handle ValueError and re-raise an Abort on failure. An arguably better solution would be to implement this logic in the vfs layer. But that seems like a bag of worms and I don't want to go down that rabbit hole. Until users report uncaught ValueError exceptions in the wild, I think it is fine to patch this at the only occurrence our test harness is finding it. Differential Revision: https://phab.mercurial-scm.org/D7944

marmoute - - Load All Authors

File last commit:

r43167:d7304434 default


                r45469:9e5b4dbe

default

Download file

             test-pushvars.t
        
                    69 lines
            
             | 1.6 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-pushvars.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      Setup

        $ PYTHONPATH=$TESTDIR/..:$PYTHONPATH

        $ export PYTHONPATH

        $ cat > $TESTTMP/pretxnchangegroup.sh << EOF

        > #!/bin/sh

        > env | egrep "^HG_USERVAR_(DEBUG|BYPASS_REVIEW)" | sort

        > exit 0

        > EOF

        $ cat >> $HGRCPATH << EOF

        > [hooks]

        > pretxnchangegroup = sh $TESTTMP/pretxnchangegroup.sh

        > EOF

        $ hg init repo

        $ hg clone -q repo child

        $ cd child

      Test pushing vars to repo with pushvars.server not set

        $ echo b > a

        $ hg commit -Aqm a

        $ hg push --pushvars "DEBUG=1" --pushvars "BYPASS_REVIEW=true"

        pushing to $TESTTMP/repo

        searching for changes

        adding changesets

        adding manifests

        adding file changes

        added 1 changesets with 1 changes to 1 files

      Setting pushvars.sever = true and then pushing.

        $ echo [push] >> $HGRCPATH

        $ echo "pushvars.server = true" >> $HGRCPATH

        $ echo b >> a

        $ hg commit -Aqm a

        $ hg push --pushvars "DEBUG=1" --pushvars "BYPASS_REVIEW=true"

        pushing to $TESTTMP/repo

        searching for changes

        adding changesets

        adding manifests

        adding file changes

        HG_USERVAR_BYPASS_REVIEW=true

        HG_USERVAR_DEBUG=1

        added 1 changesets with 1 changes to 1 files

      Test pushing var with empty right-hand side

        $ echo b >> a

        $ hg commit -Aqm a

        $ hg push --pushvars "DEBUG="

        pushing to $TESTTMP/repo

        searching for changes

        adding changesets

        adding manifests

        adding file changes

        HG_USERVAR_DEBUG=

        added 1 changesets with 1 changes to 1 files

      Test pushing bad vars

        $ echo b >> a

        $ hg commit -Aqm b

        $ hg push --pushvars "DEBUG"

        pushing to $TESTTMP/repo

        searching for changes

        abort: unable to parse variable 'DEBUG', should follow 'KEY=VALUE' or 'KEY=' format

        [255]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				Setup

				$ PYTHONPATH=$TESTDIR/..:$PYTHONPATH
				$ export PYTHONPATH

				$ cat > $TESTTMP/pretxnchangegroup.sh << EOF
				> #!/bin/sh
				> env \| egrep "^HG_USERVAR_(DEBUG\|BYPASS_REVIEW)" \| sort
				> exit 0
				> EOF
				$ cat >> $HGRCPATH << EOF
				> [hooks]
				> pretxnchangegroup = sh $TESTTMP/pretxnchangegroup.sh
				> EOF

				$ hg init repo
				$ hg clone -q repo child
				$ cd child

				Test pushing vars to repo with pushvars.server not set

				$ echo b > a
				$ hg commit -Aqm a
				$ hg push --pushvars "DEBUG=1" --pushvars "BYPASS_REVIEW=true"
				pushing to $TESTTMP/repo
				searching for changes
				adding changesets
				adding manifests
				adding file changes
				added 1 changesets with 1 changes to 1 files

				Setting pushvars.sever = true and then pushing.

				$ echo [push] >> $HGRCPATH
				$ echo "pushvars.server = true" >> $HGRCPATH
				$ echo b >> a
				$ hg commit -Aqm a
				$ hg push --pushvars "DEBUG=1" --pushvars "BYPASS_REVIEW=true"
				pushing to $TESTTMP/repo
				searching for changes
				adding changesets
				adding manifests
				adding file changes
				HG_USERVAR_BYPASS_REVIEW=true
				HG_USERVAR_DEBUG=1
				added 1 changesets with 1 changes to 1 files

				Test pushing var with empty right-hand side

				$ echo b >> a
				$ hg commit -Aqm a
				$ hg push --pushvars "DEBUG="
				pushing to $TESTTMP/repo
				searching for changes
				adding changesets
				adding manifests
				adding file changes
				HG_USERVAR_DEBUG=
				added 1 changesets with 1 changes to 1 files

				Test pushing bad vars

				$ echo b >> a
				$ hg commit -Aqm b
				$ hg push --pushvars "DEBUG"
				pushing to $TESTTMP/repo
				searching for changes
				abort: unable to parse variable 'DEBUG', should follow 'KEY=VALUE' or 'KEY=' format
				[255]