upstream/mercurial-mirror Files · rust/hg-core/src/operations/mod.rs

hgweb: encode WSGI environment using the ISO-8859-1 codec...

hgweb: encode WSGI environment using the ISO-8859-1 codec The WSGI specification (PEP 3333) specifies that on Python 3 all strings passed by the server must be of type str with code points encodable using the ISO 8859-1 codec. For some reason, I introduced a bug in by applying the reverse change. Maybe I got confused because PEP 3333 says that arbitrary operating system environment variables may be contained in the WSGI environment and therefore we need to handle the WSGI environment variables like we would handle operating system environment variables. The bug mentioned in the previous paragraph and fixed by this changeset manifested e.g. in the path of the URL being encoded in the wrong way. Browsers encode non-ASCII bytes with the percent-encoding. WSGI servers will decode the percent-encoded bytes and pass them to the application as strings where each byte is mapped to the corresponding code point with the same ordinal (i.e. it is decoded using the ISO-8859-1 codec). Mercurial uses the bytes type for these strings (which makes much more sense), so we need to encode it again using the ISO-8859-1 codec. If we use another codec, it can result in nonsense.

Raphaël Gomès - - Load All Authors

File last commit:

r50875:95ffa065 default


                r51713:9ed281bb

stable

Download file

             mod.rs
        
                    10 lines
            
             | 409 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-core / src / operations / mod.rs
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      //! A distinction is made between operations and commands.

      //! An operation is what can be done whereas a command is what is exposed by

      //! the cli. A single command can use several operations to achieve its goal.

      mod cat;

      mod debugdata;

      mod list_tracked_files;

      pub use cat::{cat, CatOutput};

      pub use debugdata::{debug_data, DebugDataKind};

      pub use list_tracked_files::{list_rev_tracked_files, FilesForRev};

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				//! A distinction is made between operations and commands.
				//! An operation is what can be done whereas a command is what is exposed by
				//! the cli. A single command can use several operations to achieve its goal.

				mod cat;
				mod debugdata;
				mod list_tracked_files;
				pub use cat::{cat, CatOutput};
				pub use debugdata::{debug_data, DebugDataKind};
				pub use list_tracked_files::{list_rev_tracked_files, FilesForRev};