upstream/mercurial-mirror Files · contrib/benchmarks/revset.py

cext: fix memory leak in phases computation...

cext: fix memory leak in phases computation Without this a buffer whose size in bytes is the number of changesets in the repository is leaked each time the repository is opened and changeset phases are computed. Impact: the current code in hgwebdir creates a new `localrepository` instance for each HTTP request. Since any pull or push is made of several requests, a team of 100 people can easily produce thousands of such requests per day. Being a low-level malloc, this leak can't be seen with the gc module and tools relying on that, but was spotted by valgrind immediately. Reproduction ------------ for i in range(cl_args.iterations): repo = hg.repository(baseui, repo_path) rev = repo.revs(rev).first() ctx = repo[rev] del ctx del repo # avoid any pollution by other type of leak # (that should be fixed in 5.8) repoview._filteredrepotypes.clear() gc.collect() Measurements ------------ Resident Set Size (RSS), taken on a clone of mozilla-central for performance analysis (440 000 changesets). before: 5.8+hg19.5ac0f2a8ba72 1000 iterations: 1606MB 5.8+hg19.5ac0f2a8ba72 10000 iterations: 5723MB after: 5.8+hg20.e2084d39e145 1000 iterations: 555MB 5.8+hg20.e2084d39e145 10000 iterations: 555MB (double checked, not a copy/paste error) (e2084d39e14 is the present changeset, before amendment of the message to add the measurements)

Augie Fackler - - Load All Authors

File last commit:

r43346:2372284d default


                r48172:9f798c1b

stable

Download file

             revset.py
        
                    57 lines
            
             | 1.6 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / contrib / benchmarks / revset.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # revset.py - asv revset benchmarks

      #

      # Copyright 2016 Logilab SA <contact@logilab.fr>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      '''ASV revset benchmarks generated from contrib/base-revsets.txt

      Each revset benchmark is parameterized with variants (first, last, sort, ...)

      '''

      from __future__ import absolute_import

      import os

      import string

      import sys

      from . import basedir, perfbench

      def createrevsetbenchmark(baseset, variants=None):

          if variants is None:

              # Default variants

              variants = ["plain", "first", "last", "sort", "sort+first", "sort+last"]

          fname = "track_" + "_".join(

              "".join(

                  [c if c in string.digits + string.letters else " " for c in baseset]

              ).split()

          )

          def wrap(fname, baseset):

              @perfbench(name=baseset, params=[("variant", variants)])

              def f(perf, variant):

                  revset = baseset

                  if variant != "plain":

                      for var in variant.split("+"):

                          revset = "%s(%s)" % (var, revset)

                  return perf("perfrevset", revset)

              f.__name__ = fname

              return f

          return wrap(fname, baseset)

      def initializerevsetbenchmarks():

          mod = sys.modules[__name__]

          with open(os.path.join(basedir, 'contrib', 'base-revsets.txt'), 'rb') as fh:

              for line in fh:

                  baseset = line.strip()

                  if baseset and not baseset.startswith('#'):

                      func = createrevsetbenchmark(baseset)

                      setattr(mod, func.__name__, func)

      initializerevsetbenchmarks()

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# revset.py - asv revset benchmarks
				#
				# Copyright 2016 Logilab SA <contact@logilab.fr>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				'''ASV revset benchmarks generated from contrib/base-revsets.txt

				Each revset benchmark is parameterized with variants (first, last, sort, ...)
				'''

				from __future__ import absolute_import

				import os
				import string
				import sys

				from . import basedir, perfbench


				def createrevsetbenchmark(baseset, variants=None):
				if variants is None:
				# Default variants
				variants = ["plain", "first", "last", "sort", "sort+first", "sort+last"]
				fname = "track_" + "_".join(
				"".join(
				[c if c in string.digits + string.letters else " " for c in baseset]
				).split()
				)

				def wrap(fname, baseset):
				@perfbench(name=baseset, params=[("variant", variants)])
				def f(perf, variant):
				revset = baseset
				if variant != "plain":
				for var in variant.split("+"):
				revset = "%s(%s)" % (var, revset)
				return perf("perfrevset", revset)

				f.__name__ = fname
				return f

				return wrap(fname, baseset)


				def initializerevsetbenchmarks():
				mod = sys.modules[__name__]
				with open(os.path.join(basedir, 'contrib', 'base-revsets.txt'), 'rb') as fh:
				for line in fh:
				baseset = line.strip()
				if baseset and not baseset.startswith('#'):
				func = createrevsetbenchmark(baseset)
				setattr(mod, func.__name__, func)


				initializerevsetbenchmarks()