upstream/mercurial-mirror Files · tests/test-abort-checkin.t

share: wrap bmstore._writerepo for transaction sensitivity (issue4940)...

share: wrap bmstore._writerepo for transaction sensitivity (issue4940) made 'bmstore.write()' transaction sensitive, to restore original bookmarks correctly at failure of a transaction. For example, shelve and unshelve imply steps below: before 46dec89fe888: 1. move active bookmark forward at internal rebasing 2. 'bmstore.write()' writes updated ones into .hg/bookmarks 3. rollback transaction to remove internal commits 4. restore updated bookmarks manually after 46dec89fe888: 1. move active bookmark forward at internal rebasing 2. 'bmstore.write()' doesn't write updated ones into .hg/bookmarks (these are written into .hg/bookmarks.pending, if external hook is spawn) 3. rollback transaction to remove internal commits 4. .hg/bookmarks should be clean, because it isn't changed while transaction running: see (2) above But if shelve or unshelve is executed in the repository created with "shared bookmarks" ("hg share -B"), this doesn't work as expected, because: - share extension makes 'bmstore.write()' write updated bookmarks into .hg/bookmarks of shared source repository regardless of transaction activity, and - intentional transaction failure at the end of shelve/unshelve doesn't restore already updated .hg/bookmarks of shared source This patch makes share extension wrap 'bmstore._writerepo()' instead of 'bmstore.write()', because the former is used to actually write bookmark changes out.

Pierre-Yves David - - Load All Authors

File last commit:

r26587:56b2bcea default


                r26933:a7eecd02

stable

Download file

             test-abort-checkin.t
        
                    37 lines
            
             | 870 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-abort-checkin.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ cat > abortcommit.py <<EOF

        > from mercurial import error

        > def hook(**args):

        >     raise error.Abort("no commits allowed")

        > def reposetup(ui, repo):

        >     repo.ui.setconfig("hooks", "pretxncommit.nocommits", hook)

        > EOF

        $ abspath=`pwd`/abortcommit.py

        $ cat <<EOF >> $HGRCPATH

        > [extensions]

        > mq =

        > abortcommit = $abspath

        > EOF

        $ hg init foo

        $ cd foo

        $ echo foo > foo

        $ hg add foo

      mq may keep a reference to the repository so __del__ will not be

      called and .hg/journal.dirstate will not be deleted:

        $ hg ci -m foo

        error: pretxncommit.nocommits hook failed: no commits allowed

        transaction abort!

        rollback completed

        abort: no commits allowed

        [255]

        $ hg ci -m foo

        error: pretxncommit.nocommits hook failed: no commits allowed

        transaction abort!

        rollback completed

        abort: no commits allowed

        [255]

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ cat > abortcommit.py <<EOF
				> from mercurial import error
				> def hook(**args):
				> raise error.Abort("no commits allowed")
				> def reposetup(ui, repo):
				> repo.ui.setconfig("hooks", "pretxncommit.nocommits", hook)
				> EOF
				$ abspath=`pwd`/abortcommit.py

				$ cat <<EOF >> $HGRCPATH
				> [extensions]
				> mq =
				> abortcommit = $abspath
				> EOF

				$ hg init foo
				$ cd foo
				$ echo foo > foo
				$ hg add foo

				mq may keep a reference to the repository so __del__ will not be
				called and .hg/journal.dirstate will not be deleted:

				$ hg ci -m foo
				error: pretxncommit.nocommits hook failed: no commits allowed
				transaction abort!
				rollback completed
				abort: no commits allowed
				[255]
				$ hg ci -m foo
				error: pretxncommit.nocommits hook failed: no commits allowed
				transaction abort!
				rollback completed
				abort: no commits allowed
				[255]

				$ cd ..